-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: remove branch-up-to-date requirement #3610
Comments
The requirement was added to ensure that all linters/etc. currently on the main branch have run against the PR. #512 (comment) |
@Oberon00 that sounds like it makes the process harder for everyone in perpetuity for the benefit of someone adding a new linter once a year. I see that pretty much everyone was agreeing with your original ticket to remove the restriction. We can come up with another process for forcing all open PR to undergo a new linting rule, e.g. by closing/re-opening them once. |
Another issue also in favor of non-blocking #936 where everyone agreed |
I support lessening the impact of linters. |
I see two issues with linters:
So I can see that there are indeed not straightforward issues, which if not address would create many other headaches if the uptodate requirement is disabled. It sounds like we need to solve them first. Question: do we currently run any bots like that? I know some orgs like k8s do. |
Per (https://github.com/open-telemetry/community/blob/main/docs/how-to-configure-new-repository.md) you can turn this off if you want. |
(in particular)
|
Done. |
What are you trying to achieve?
I often see a PR with required approvals ready to merge, but the merge button is disabled because the branch is not up to date. This leads to one of maintainers hitting Update Branch button and then forgetting about the issue until someone else comes across it and it's out of date with main again.
I propose to remove that up-to-date requirement. It makes much more sense in the code repositories, but for mostly text repos it does not provide a lot of benefit. GitHub won't allow to merge if there are conflicts, but aside from that merging slightly stale branch is usually not a problem.
The text was updated successfully, but these errors were encountered: