From 222ebf231be996764b789f7ffc8e001d4f269ef5 Mon Sep 17 00:00:00 2001 From: Armin Ruech <7052238+arminru@users.noreply.github.com> Date: Tue, 8 Oct 2024 18:38:21 +0200 Subject: [PATCH 1/3] Update spec-compliance-matrix.md for Go temporality preference (#4246) --- spec-compliance-matrix.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec-compliance-matrix.md b/spec-compliance-matrix.md index 790875d9e32..69918f38f08 100644 --- a/spec-compliance-matrix.md +++ b/spec-compliance-matrix.md @@ -291,7 +291,7 @@ Note: Support for environment variables is optional. | OTEL_METRIC_EXPORT_INTERVAL | - | + | | + | | | + | | | + | | | OTEL_METRIC_EXPORT_TIMEOUT | - | - | | + | | | + | | | + | | | OTEL_METRICS_EXEMPLAR_FILTER | - | + | | | | | + | | | + | | -| OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE | - | + | + | + | | | + | | | + | | +| OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE | + | + | + | + | | | + | | | + | | | OTEL_EXPORTER_OTLP_METRICS_DEFAULT_HISTOGRAM_AGGREGATION | | + | | + | | | | | | | | | OTEL_EXPERIMENTAL_CONFIG_FILE | | | | | | | | | | | | From 893602fc70eabab4a87b83bdb5e09f87fcd4a02c Mon Sep 17 00:00:00 2001 From: Cijo Thomas Date: Tue, 8 Oct 2024 09:38:38 -0700 Subject: [PATCH 2/3] Mark MetricReader cardinality limit as stable (#4245) --- specification/metrics/sdk.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/metrics/sdk.md b/specification/metrics/sdk.md index ca9aa54c11b..ecb2b1b217d 100644 --- a/specification/metrics/sdk.md +++ b/specification/metrics/sdk.md @@ -1231,7 +1231,7 @@ SHOULD be provided: * The `exporter` to use, which is a `MetricExporter` instance. * The default output `aggregation` (optional), a function of instrument kind. This function SHOULD be obtained from the `exporter`. If not configured, the [default aggregation](#default-aggregation) SHOULD be used. * The output `temporality` (optional), a function of instrument kind. This function SHOULD be obtained from the `exporter`. If not configured, the Cumulative temporality SHOULD be used. -* **Status**: [Development](../document-status.md) - The default aggregation cardinality limit to use, a function of instrument kind. If not configured, a default value of 2000 SHOULD be used. +* The default aggregation [cardinality limit](#cardinality-limits) (optional) to use, a function of instrument kind. If not configured, a default value of 2000 SHOULD be used. * **Status**: [Development](../document-status.md) - The [MetricFilter](#metricfilter) to apply to metrics and attributes during `MetricReader#Collect`. * Zero of more [MetricProducer](#metricproducer)s (optional) to collect metrics from in addition to metrics from the SDK. From 630896f88c4d29ca7e0edbf070b872f8d41fd0f3 Mon Sep 17 00:00:00 2001 From: Damien Mathieu <42@dmathieu.com> Date: Tue, 8 Oct 2024 18:40:05 +0200 Subject: [PATCH 3/3] Make the end timestamp and mutable span as requirements in onending (#4240) --- specification/trace/sdk.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/specification/trace/sdk.md b/specification/trace/sdk.md index 07755ca56dd..765edc4b296 100644 --- a/specification/trace/sdk.md +++ b/specification/trace/sdk.md @@ -607,7 +607,10 @@ are invoked in the order they have been registered. **Status**: [Development](../document-status.md) -`OnEnding` is called during the span `End()` operation, after the end timestamp has been set. The Span object is still mutable (i.e., `SetAttribute`, `AddLink`, `AddEvent` can be called) while `OnEnding` is called. +`OnEnding` is called during the span `End()` operation. +The end timestamp MUST have been computed (the `OnEnding` method duration is not included +in the span duration). +The Span object MUST still be mutable (i.e., `SetAttribute`, `AddLink`, `AddEvent` can be called) while `OnEnding` is called. This method MUST be called synchronously within the [`Span.End()` API](api.md#end), therefore it should not block or throw an exception. If multiple `SpanProcessors` are registered, their `OnEnding` callbacks