Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate some pyright tests #4086

Open
xrmx opened this issue Jul 26, 2024 · 4 comments
Open

Investigate some pyright tests #4086

xrmx opened this issue Jul 26, 2024 · 4 comments

Comments

@xrmx
Copy link
Contributor

xrmx commented Jul 26, 2024

Is your feature request related to a problem?

It looks like pyright is good at catching issues with types annotations, e.g.

It would make sense to catch these kind of issues earlier.

Describe the solution you'd like

We can add some basic tests, I think the two snippets from the mentioned issues may be enough to start.

Describe alternatives you've considered

Maybe mypy will catch these too so pyright won't be needed. Maybe it would enough to add annotations to the examples we already have and run a type checker against them.

Additional Context

No response

Would you like to implement a fix?

None

@Ali-Alnosairi
Copy link
Contributor

Hello @xrmx ,
would you assign this to me !

@Ali-Alnosairi
Copy link
Contributor

Hi @xrmx ,
How to reproduce the issue .
would you please help!

@RichardChukwu
Copy link

RichardChukwu commented Oct 8, 2024

Hello @lzchen is this still being worked on please.

Open to be assigned to it, thank you

@xrmx
Copy link
Contributor Author

xrmx commented Oct 8, 2024

A test has been added, here there are some hints on how to continue the work
#4172 (comment)

But first you need to build some confidence with python typing I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants