From bd7cf55b6d45f3c587d2131b68a7e5a501bdb10c Mon Sep 17 00:00:00 2001 From: Long Yang Date: Thu, 6 Jun 2024 01:38:21 +0800 Subject: [PATCH] Fix typo; According to the definition of message Sample, the relation between Sample and Link should be n-1 (#564) --- opentelemetry/proto/profiles/v1experimental/pprofextended.proto | 2 +- opentelemetry/proto/profiles/v1experimental/profiles.proto | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/opentelemetry/proto/profiles/v1experimental/pprofextended.proto b/opentelemetry/proto/profiles/v1experimental/pprofextended.proto index 5ebe1fd93..b5b5b88fc 100644 --- a/opentelemetry/proto/profiles/v1experimental/pprofextended.proto +++ b/opentelemetry/proto/profiles/v1experimental/pprofextended.proto @@ -205,7 +205,7 @@ enum AggregationTemporality { 11. A request is received, the system measures 1 request. 12. The 1 second collection cycle ends. A metric is exported for the number of requests received over the interval of time t_1 to - t_0+1 with a value of 1. + t_1+1 with a value of 1. Note: Even though, when reporting changes since last report time, using CUMULATIVE is valid, it is not recommended. */ diff --git a/opentelemetry/proto/profiles/v1experimental/profiles.proto b/opentelemetry/proto/profiles/v1experimental/profiles.proto index bbc2b2931..84b0108f8 100644 --- a/opentelemetry/proto/profiles/v1experimental/profiles.proto +++ b/opentelemetry/proto/profiles/v1experimental/profiles.proto @@ -55,7 +55,7 @@ option go_package = "go.opentelemetry.io/proto/otlp/profiles/v1experimental"; // ┌──────────────────┐ // │ Profile │ // └──────────────────┘ -// │ 1-n +// │ n-1 // │ 1-n ┌───────────────────────────────────────┐ // ▼ │ ▽ // ┌──────────────────┐ 1-n ┌──────────────┐ ┌──────────┐