Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include more than just the method in opentelemetry-auto-symfony HttpClientInstrumentation #1399

Open
NeilWhitworth opened this issue Oct 11, 2024 · 3 comments

Comments

@NeilWhitworth
Copy link

Is your feature request related to a problem?
We are consuming an api (served from api.example.com) that references images (served from images.example.com). However since all http(s) requests only use the method as the span name, it is impossible to distinguish requests going to the different hosts.

Describe the solution you'd like
Include additional distinguishing information in the span name. Possibly using the target url host-name

Describe alternatives you've considered

  • Use the target request schema/host/port combination
  • Use base_uri if available

Additional context
From to https://opentelemetry.io/docs/specs/semconv/http/http-spans/

HTTP span names SHOULD be {method} {target} if there is a (low-cardinality) target available.

Instrumentation MUST NOT default to using URI path as a {target}

@brettmc
Copy link
Collaborator

brettmc commented Oct 13, 2024

HTTP span names SHOULD be {method} {target} if there is a (low-cardinality) target available.
Instrumentation MUST NOT default to using URI path as a {target}

This is the heart of the issue. We cannot move URI & friends up into the span name, and so far we have not come up with a way to create a low-cardinality target from a general URI.

I think this is actually a UI issue, and you need a way to "pull up" existing span metadata and display it alongside the span's name - interesting parts of the URI are already stored against the span, in other attributes such as URL_FULL, URL_PATH...

@dkarlovi
Copy link
Contributor

dkarlovi commented Oct 16, 2024

@brettmc why not at least use the hostname, that should count as low cardinality.

POST api.example.com

much better than

POST

@brettmc
Copy link
Collaborator

brettmc commented Oct 16, 2024

why not at least use the hostname

That's what was proposed in the linked PR. Can discuss over there: open-telemetry/opentelemetry-php-contrib#305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants