-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for k8s labels such as app.kubernetes.io/name #3112
Comments
@zeitlinger is this different from this issue? Wondering if i can merge these together. |
didn't know about it
|
I think i prefer the |
changed |
@zeitlinger i added the discuss-at-sig label as it seems from Tyler's comment on the PR that there's some bigger picture stuff we need to figure out in order to not break users. We have a SIG meeting tomorrow (8/29) at noon EST where we will discuss this. |
great - I'll join |
Component(s)
auto-instrumentation
Is your feature request related to a problem? Please describe.
k8s labels such as app.kubernetes.io/name are recommended to set the app name and similar
See https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
this should be supported by the otel operator
Describe the solution you'd like
This mapping should work for the following labels:
app.kubernetes.io/name
-service.name
app.kubernetes.io/instance
-service.instance.id
app.kubernetes.io/version
-service.version
app.kubernetes.io/part-of
-service.namespace
And for the following annotations:
opentelemetry.io/resource.foo
-foo
(for any key) - note that the k8sattributes processor can also process those annotations, see Copy multiple attributes/labels in k8sattributes opentelemetry-collector-contrib#34040Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: