add stdout memory mode #6774
add stdout memory mode #6774
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6774 +/- ##
============================================
+ Coverage 90.10% 90.61% +0.51%
- Complexity 6541 6585 +44
============================================
Files 728 731 +3
Lines 19695 19722 +27
Branches 1935 1926 -9
============================================
+ Hits 17746 17871 +125
+ Misses 1349 1254 -95
+ Partials 600 597 -3 ☔ View full report in Codecov by Sentry. |
|
@jack-berg this is the final PR for stdout - adding the memory mode feature |
|
|
||
| import io.opentelemetry.sdk.common.export.MemoryMode; | ||
|
|
||
| public class OtlpStdoutExporterBuilderUtil { |
There was a problem hiding this comment.
Missing internal boilerplate javadoc.
There was a problem hiding this comment.
why did the build not fail?
There was a problem hiding this comment.
There's not a build check for it right now. Do you know if opentelemetry-java-instrumentation managed to add this automation yet?
There was a problem hiding this comment.
...main/java/io/opentelemetry/exporter/logging/otlp/internal/OtlpStdoutExporterBuilderUtil.java
Outdated
Show resolved
Hide resolved
...mon/src/main/java/io/opentelemetry/exporter/internal/otlp/logs/LogReusableDataMarshaler.java
Outdated
Show resolved
Hide resolved
...n/java/io/opentelemetry/exporter/logging/otlp/internal/logs/OtlpStdoutLogRecordExporter.java
Outdated
Show resolved
Hide resolved
| public CompletableResultCode doExport(Marshaler exportRequest, int numItems) { | ||
| return jsonWriter.write(exportRequest); | ||
| } | ||
| }.export(logs); | ||
| } else { | ||
| for (ResourceLogsMarshaler resourceLogs : ResourceLogsMarshaler.create(logs)) { |
There was a problem hiding this comment.
It doesn't seem to be the case that if wrapperJsonObject = false, we can't take advantage of reuseable memory mode. Can we include wrapperJsonObject as an argument to LogReuseableDataMarshaler and adjust the logic accordingly?
There was a problem hiding this comment.
that's not so easy, because
takes a list and I didn't follow what has to be modified in there
...n/java/io/opentelemetry/exporter/logging/otlp/internal/metrics/OtlpStdoutMetricExporter.java
Show resolved
Hide resolved
zeitlinger
force-pushed
the
stdout-memory-mode
branch
from
d5021a9
to
cfabe23
Compare
No description provided.