Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config options to prometheus exporter #3104

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

psx95
Copy link

@psx95 psx95 commented Oct 16, 2024

Fixes #2453

Changes

Added the following optional configuration options (booleans) to the prometheus exporter:

  • without_units : controls whether to add unit suffixes (e.g. _seconds) to the metric names.
  • without_type_suffix: controls whether to add type suffixes (e.g. _total) to the metric names.
  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 19d20cf
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67111f3a1e28b1000856202c

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.83%. Comparing base (497eaf4) to head (19d20cf).
Report is 142 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3104      +/-   ##
==========================================
+ Coverage   87.12%   87.83%   +0.71%     
==========================================
  Files         200      195       -5     
  Lines        6109     5969     -140     
==========================================
- Hits         5322     5242      -80     
+ Misses        787      727      -60     

see 125 files with indirect coverage changes

@psx95 psx95 marked this pull request as ready for review October 16, 2024 21:39
@psx95 psx95 requested a review from a team as a code owner October 16, 2024 21:39
@psx95 psx95 changed the title Add optional config to prometheus exporter Add config options to prometheus exporter Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EXPORTER] Add optional configuration for prometheus exporter
1 participant