Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Remove std::make_unique #3098

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

owent
Copy link
Member

@owent owent commented Oct 16, 2024

Fixes #3096

Changes

  • Remove std::make_unique

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team as a code owner October 16, 2024 08:10
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit fd07a0f
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/670f750dc854a2000853b35d

@owent owent mentioned this pull request Oct 16, 2024
3 tasks
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.82%. Comparing base (497eaf4) to head (fd07a0f).
Report is 141 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3098      +/-   ##
==========================================
+ Coverage   87.12%   87.82%   +0.71%     
==========================================
  Files         200      195       -5     
  Lines        6109     5968     -141     
==========================================
- Hits         5322     5241      -81     
+ Misses        787      727      -60     
Files with missing lines Coverage Δ
...rs/memory/src/in_memory_metric_exporter_factory.cc 100.00% <100.00%> (ø)
...xporters/memory/test/in_memory_metric_data_test.cc 100.00% <100.00%> (ø)

... and 125 files with indirect coverage changes

@marcalff marcalff changed the title Remove std::make_unique [BUILD] Remove std::make_unique Oct 16, 2024
@marcalff marcalff merged commit 70ed9bc into open-telemetry:main Oct 16, 2024
56 checks passed
@owent owent deleted the fix_make_unique branch October 16, 2024 10:24
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not compile when using WITH_STL=CXX11 with legacy toolchain
2 participants