Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Jaeger Propagator should not be deprecated #3086

Merged
merged 7 commits into from
Oct 8, 2024

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Oct 7, 2024

Fixes #3077

Changes

Please provide a brief description of the changes here.

Revert the deprecation of the Jeager propagator.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team as a code owner October 7, 2024 21:18
Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit b871904
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/670550ff002d81000880f73d

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.82%. Comparing base (497eaf4) to head (b871904).
Report is 139 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3086      +/-   ##
==========================================
+ Coverage   87.12%   87.82%   +0.71%     
==========================================
  Files         200      195       -5     
  Lines        6109     5968     -141     
==========================================
- Hits         5322     5241      -81     
+ Misses        787      727      -60     
Files with missing lines Coverage Δ
...i/include/opentelemetry/trace/propagation/jaeger.h 97.78% <ø> (ø)

... and 125 files with indirect coverage changes

@marcalff marcalff added the pr:please-review This PR is ready for review label Oct 7, 2024
@marcalff marcalff merged commit 6445819 into open-telemetry:main Oct 8, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:please-review This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jaeger Propagator should not be deprecated
2 participants