Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EXPORTER] All 2xx return codes should be considered successful. #2712

Merged
merged 3 commits into from
Jun 21, 2024
Merged

[EXPORTER] All 2xx return codes should be considered successful. #2712

merged 3 commits into from
Jun 21, 2024

Conversation

owent
Copy link
Member

@owent owent commented Jun 21, 2024

Fixes #2632

Changes

According to https://datatracker.ietf.org/doc/html/rfc7231#page-47 . All 2xx return codes should be considered successful.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team June 21, 2024 06:27
marcalff
marcalff reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See issue in the zipkin exporter, errors are not detected.

@marcalff marcalff changed the title All 2xx return codes should be considered successful. [EXPORTER] All 2xx return codes should be considered successful. Jun 21, 2024
marcalff
marcalff approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit 4e86a86 into open-telemetry:main Jun 21, 2024
50 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jun 21, 2024
Merged
@owent owent deleted the treat_all_2xx_http_code_as_successful branch June 29, 2024 17:26
@loafoe loafoe mentioned this pull request Jul 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalff marcalff marcalff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is a 204 status code error something I should worry about when using opentelemetry-cpp.
2 participants
@owent @marcalff