Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXPORTER] Set is_monotonic flag for Observable Counters #2478

Merged

Conversation

samin36
Copy link
Contributor

@samin36 samin36 commented Jan 6, 2024

Fixes #2469

Changes

Please provide a brief description of the changes here.

The is_monotonic flag is now set to true for both synchronous and asynchronous/observable counters.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@samin36 samin36 requested a review from a team January 6, 2024 20:49
Copy link

linux-foundation-easycla bot commented Jan 6, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74db5e6) 87.06% compared to head (f5c6e07) 87.06%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2478   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files         199      199           
  Lines        6087     6087           
=======================================
  Hits         5299     5299           
  Misses        788      788           

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit 928a87c into open-telemetry:main Jan 8, 2024
46 checks passed
@marcalff marcalff changed the title Set is_monotonic flag for Observable Counters [EXPORTER] Set is_monotonic flag for Observable Counters Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTLP Exporter does not set an observable counter as monotonic
3 participants