Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute filtering for synchronous instruments. #2472

Merged
merged 13 commits into from
Feb 8, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jan 2, 2024

Fixes #2468

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team January 2, 2024 20:11
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (497eaf4) 87.12% compared to head (12f3ee2) 87.02%.
Report is 1 commits behind head on main.

❗ Current head 12f3ee2 differs from pull request most recent head 3105173. Consider uploading reports for the commit 3105173 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2472      +/-   ##
==========================================
- Coverage   87.12%   87.02%   -0.10%     
==========================================
  Files         200      202       +2     
  Lines        6109     6129      +20     
==========================================
+ Hits         5322     5333      +11     
- Misses        787      796       +9     
Files Coverage Δ
...ude/opentelemetry/sdk/metrics/data/exemplar_data.h 0.00% <ø> (ø)
...nclude/opentelemetry/sdk/metrics/exemplar/filter.h 100.00% <ø> (ø)
...nclude/opentelemetry/sdk/metrics/observer_result.h 100.00% <100.00%> (+7.70%) ⬆️
...entelemetry/sdk/metrics/state/attributes_hashmap.h 92.31% <100.00%> (-0.11%) ⬇️
...ntelemetry/sdk/metrics/state/sync_metric_storage.h 86.37% <100.00%> (ø)
...ntelemetry/sdk/metrics/view/attributes_processor.h 85.00% <ø> (-5.00%) ⬇️
...sdk/metrics/state/filtered_ordered_attribute_map.h 57.15% <57.15%> (ø)
...rc/metrics/state/filtered_ordered_attribute_map.cc 58.83% <58.83%> (ø)

... and 3 files with indirect coverage changes

@lalitb lalitb changed the title [WIP] Fix filtering attribute processor [WIP] Fix attribute filtering for synchronous instruments. Jan 2, 2024
@lalitb lalitb changed the title [WIP] Fix attribute filtering for synchronous instruments. Fix attribute filtering for synchronous instruments. Jan 3, 2024
@lalitb lalitb merged commit cf5cdaa into open-telemetry:main Feb 8, 2024
47 checks passed
@lalitb lalitb mentioned this pull request Feb 27, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics: FilteringAttributesProcessor has no effect
2 participants