Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Benchmark workflow fails, C++14 required to build grpc #2278

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Aug 24, 2023

Fixes #2083

Changes

There are two benchmarks workflows defined in CI:

  • per PR push benchmark (ci.yml)
  • benchmark on the main branch (benchmark.yml)

The former uses local tests, while the later uses an opentelemetry collector in docker.

Currently, ci.yml builds properly, while benchmark.yml fails to build.

Fixed the build for benchmark.yml:

  • aligned the workflow definition on ci.yml
  • in do_ci.sh, aligned compiler flags for bazel.benchmark on flags used in benchmark

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team August 24, 2023 10:14
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #2278 (a4e5724) into main (628838a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2278   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files         199      199           
  Lines        5981     5981           
=======================================
  Hits         5234     5234           
  Misses        747      747           

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@marcalff marcalff merged commit 7196ec3 into open-telemetry:main Aug 25, 2023
44 checks passed
@marcalff marcalff deleted the fix_ci_benchmark_2083 branch September 5, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Benchmark workflow fails, C++14 required to build grpc
2 participants