Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OStreamLogRecordExporterFactory #2240

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Add OStreamLogRecordExporterFactory #2240

merged 2 commits into from
Jul 20, 2023

Conversation

owent
Copy link
Member

@owent owent commented Jul 20, 2023

Fixes #2239

Changes

  • Add OStreamLogRecordExporterFactory

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team July 20, 2023 03:59
@owent owent changed the title Add OStreamLogRecordExporterFactory [WIP] Add OStreamLogRecordExporterFactory Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023 •
edited
Loading

Codecov Report

Merging #2240 (2f11ef0) into main (038e65d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2240   +/-   ##
=======================================
  Coverage   87.31%   87.31%           
=======================================
  Files         169      169           
  Lines        4900     4900           
=======================================
  Hits         4278     4278           
  Misses        622      622

@owent owent changed the title [WIP] Add OStreamLogRecordExporterFactory Add OStreamLogRecordExporterFactory Jul 20, 2023
lalitb
lalitb approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

marcalff
marcalff approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

exporters/ostream/CMakeLists.txt Show resolved Hide resolved
@marcalff
Copy link
Member

Open comment marked as resolved, so merging now.

@marcalff marcalff merged commit 2974eb8 into open-telemetry:main Jul 20, 2023
42 checks passed
@owent owent deleted the add_ostream_log_record_exporter_factory branch July 26, 2023 05:00
@chenrui333 chenrui333 mentioned this pull request Aug 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

@marcalff marcalff marcalff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OSTREAM EXPORTER] Add factory for OStreamLogRecordExporter
3 participants
@owent @marcalff @lalitb