[CI] Misc build scripts cleanup #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2232 +/- ##
=======================================
Coverage ? 87.31%
=======================================
Files ? 169
Lines ? 4900
Branches ? 0
=======================================
Hits ? 4278
Misses ? 622
Partials ? 0 |
|
Ready for review. |
ThomsonTan
reviewed
Jul 12, 2023
| if(BUILD_TESTING) | ||
| if(MSVC) | ||
| # Warning as error: warning STL4036: <ciso646> is removed in C++20 | ||
| add_compile_options(/wd4996) |
There was a problem hiding this comment.
Why is this option no longer needed?
There was a problem hiding this comment.
The opentelemetry-cpp code does not even include header ciso464, and the build passes in maintainer mode on windows without the option, even when tests are compiled, with the dependency in GTest.
PR#2114 added this, but I think it was not needed.
This fix corrects it, and resolves your comment:
https://github.com/open-telemetry/opentelemetry-cpp/pull/2114/files#r1260156709
lalitb
approved these changes
Jul 12, 2023
ThomsonTan
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Misc cleanup in build scripts:
/wd4996on windows.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes