Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark run is broken in CI #2620

Closed
marcalff opened this issue Mar 28, 2024 · 0 comments · Fixed by #2621
Closed

Benchmark run is broken in CI #2620

marcalff opened this issue Mar 28, 2024 · 0 comments · Fixed by #2621
Assignees
Labels
bug Something isn't working

Comments

@marcalff
Copy link
Member

Since the merge of #2597 to main, the CI benchmark fails with:

Status: Downloaded newer image for itchyny/gojq:0.12.6
gojq: invalid json: <stdin>:39
    39 | -- LOG(0): Value passed to --benchmark_min_time should have a suf
          ^  invalid character '-' in numeric literal
Error: Process completed with exit code 5.

I suspect the problem is due to the following breaking change in benchmark:

@marcalff marcalff added the bug Something isn't working label Mar 28, 2024
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 28, 2024
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Mar 28, 2024
@marcalff marcalff self-assigned this Mar 28, 2024
@marcalff marcalff removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant