Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] Incorrect test on ENABLE_OTLP_GRPC_SSL_MTLS_PREVIEW #2545

Closed
marcalff opened this issue Feb 21, 2024 · 0 comments · Fixed by #2546
Closed

[BUILD] Incorrect test on ENABLE_OTLP_GRPC_SSL_MTLS_PREVIEW #2545

marcalff opened this issue Feb 21, 2024 · 0 comments · Fixed by #2546
Labels
bug Something isn't working

Comments

@marcalff
Copy link
Member

In the OTLP GRPC code, usage of the ENABLE_OTLP_GRPC_SSL_MTLS_PREVIEW flag is incorrect.

/data/malff/CODE/MY_GITHUB/opentelemetry-cpp/exporters/otlp
[malff@malff-desktop otlp]$ grep -R ENABLE_OTLP_GRPC_SSL_MTLS_PREVIEW *
include/opentelemetry/exporters/otlp/otlp_grpc_client_options.h:#ifdef ENABLE_OTLP_GRPC_SSL_MTLS_PREVIEW
src/otlp_grpc_client.cc:#if ENABLE_OTLP_GRPC_SSL_MTLS_PREVIEW
src/otlp_grpc_metric_exporter_options.cc:#ifdef ENABLE_OTLP_GRPC_SSL_MTLS_PREVIEW
src/otlp_grpc_exporter_options.cc:#ifdef ENABLE_OTLP_GRPC_SSL_MTLS_PREVIEW
src/otlp_grpc_log_record_exporter_options.cc:#ifdef ENABLE_OTLP_GRPC_SSL_MTLS_PREVIEW

File src/otlp_grpc_client.cc should use ifdef, not if.
@marcalff marcalff added the bug Something isn't working label Feb 21, 2024
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 21, 2024
@marcalff marcalff mentioned this issue Feb 21, 2024
Open
50 tasks
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Feb 21, 2024
@marcalff
Fix open-telemetry#2545
0b966f8
@marcalff marcalff mentioned this issue Feb 21, 2024
Merged
3 tasks
@marcalff marcalff removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUILD] Incorrect test on ENABLE_OTLP_GRPC_SSL_MTLS_PREVIEW marcalff/opentelemetry-cpp
1 participant
@marcalff