Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DLL export interface for Metrics #2313

Closed
ThomsonTan opened this issue Sep 14, 2023 Discussed in #2311 · 1 comment · Fixed by #2344
Closed

DLL export interface for Metrics #2313

ThomsonTan opened this issue Sep 14, 2023 Discussed in #2311 · 1 comment · Fixed by #2344
Labels
help wanted Good for taking. Extra help will be provided by maintainers triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ThomsonTan
Copy link
Contributor

Discussed in #2311

Originally posted by TomSvk88 September 14, 2023
Hi,

I can see from the code itself that Traces and Logs classes as exported as dll interface but Metrics classes are not. Is there any particular reason for that or is it just it was not added yet?
Thank you for any response.

Tomas
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 14, 2023
@ThomsonTan ThomsonTan added help wanted Good for taking. Extra help will be provided by maintainers and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 14, 2023
@github-actions
Copy link

This issue is available for anyone to work on. Make sure to reference this issue in your pull request.
✨ Thank you for your contribution! ✨

@ThomsonTan ThomsonTan added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 14, 2023
@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 20, 2023
@perhapsmaple perhapsmaple mentioned this issue Oct 7, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Good for taking. Extra help will be provided by maintainers triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUILD] DLL export interface for Metrics perhapsmaple/opentelemetry-cpp
2 participants
@ThomsonTan @marcalff