Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics API] The Record method of class Histogram now must have a context param, but in the Add method of class Counter it is optional #2155

Closed
xieyuguang opened this issue May 24, 2023 · 2 comments · Fixed by #2416
Closed

[Metrics API] The Record method of class Histogram now must have a context param, but in the Add method of class Counter it is optional #2155

xieyuguang opened this issue May 24, 2023 · 2 comments · Fixed by #2416
Labels
breaking change API or ABI breaking change do-not-stale
Milestone
Metrics post GA r...

Comments

@xieyuguang
Copy link

The Record method of class Histogram now must have a context param, but in the Add method of class Counter it is optional. This brings confusion to users.
@xieyuguang xieyuguang changed the title [Metrics API]the Record method of class Histogram now must have a context param, but in the Add method of class Counter it is optional [Metrics API] The Record method of class Histogram now must have a context param, but in the Add method of class Counter it is optional May 24, 2023
@lalitb
Copy link
Member

lalitb commented May 25, 2023

Yes agree, Histogram should have overload method without Context, to be consistent with other instruments. This can be accommodate as part a ABI breaking release whenever planned.

@lalitb lalitb added the breaking change API or ABI breaking change label May 25, 2023
@lalitb lalitb mentioned this issue May 25, 2023
Closed
@lalitb lalitb added this to the Metrics post GA release - 2 milestone Jun 19, 2023
@github-actions
Copy link

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Aug 19, 2023
@lalitb lalitb added do-not-stale and removed Stale labels Aug 19, 2023
@lalitb lalitb mentioned this issue Sep 29, 2023
Closed
3 tasks
@ThomsonTan ThomsonTan mentioned this issue Nov 29, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change API or ABI breaking change do-not-stale
Projects
None yet
Milestone
Metrics post GA release - 2
2 participants
@lalitb @xieyuguang