From 3d51b3d47e1b8a93fd7347808a07467fdca98240 Mon Sep 17 00:00:00 2001
From: Punya Biswal <punya.biswal@gmail.com>
Date: Sat, 31 Aug 2024 17:12:48 -0400
Subject: [PATCH] Implement in-memory metric exporter

Fixes #1405
---
 .../exporters/memory/in_memory_metric_data.h             | 9 +++++----
 .../exporters/memory/in_memory_metric_exporter_factory.h | 5 +----
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/exporters/memory/include/opentelemetry/exporters/memory/in_memory_metric_data.h b/exporters/memory/include/opentelemetry/exporters/memory/in_memory_metric_data.h
index 66c36c2693..5afd4b5457 100644
--- a/exporters/memory/include/opentelemetry/exporters/memory/in_memory_metric_data.h
+++ b/exporters/memory/include/opentelemetry/exporters/memory/in_memory_metric_data.h
@@ -6,7 +6,8 @@
 #include "opentelemetry/exporters/memory/in_memory_data.h"
 #include "opentelemetry/sdk/metrics/export/metric_producer.h"
 
-#include <vector>
+#include <map>
+#include <tuple>
 
 OPENTELEMETRY_BEGIN_NAMESPACE
 namespace exporter
@@ -19,14 +20,14 @@ namespace memory
 class InMemoryMetricData
 {
 public:
-  InMemoryMetricData(){};
+  InMemoryMetricData()          = default;
+  virtual ~InMemoryMetricData() = default;
+
   InMemoryMetricData(const InMemoryMetricData &)            = delete;
   InMemoryMetricData(InMemoryMetricData &&)                 = delete;
   InMemoryMetricData &operator=(const InMemoryMetricData &) = delete;
   InMemoryMetricData &operator=(InMemoryMetricData &&)      = delete;
 
-  virtual ~InMemoryMetricData() = default;
-
   virtual void Add(std::unique_ptr<sdk::metrics::ResourceMetrics> resource_metrics) = 0;
 };
 
diff --git a/exporters/memory/include/opentelemetry/exporters/memory/in_memory_metric_exporter_factory.h b/exporters/memory/include/opentelemetry/exporters/memory/in_memory_metric_exporter_factory.h
index c6499c8f01..82c24baf6f 100644
--- a/exporters/memory/include/opentelemetry/exporters/memory/in_memory_metric_exporter_factory.h
+++ b/exporters/memory/include/opentelemetry/exporters/memory/in_memory_metric_exporter_factory.h
@@ -3,11 +3,8 @@
 
 #pragma once
 
-#include <atomic>
-#include <vector>
+#include <memory>
 
-#include "opentelemetry/exporters/memory/in_memory_data.h"
-#include "opentelemetry/sdk/metrics/export/metric_producer.h"
 #include "opentelemetry/sdk/metrics/instruments.h"
 #include "opentelemetry/sdk/metrics/push_metric_exporter.h"
 #include "opentelemetry/version.h"