Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/redaction] Add support for allowed values that are never redacted #35840

Open
janslow opened this issue Oct 16, 2024 · 1 comment
Open
Labels
enhancement New feature or request needs triage New item requiring triage processor/redaction Redaction processor

Comments

@janslow
Copy link

janslow commented Oct 16, 2024

Component(s)

processor/redaction

Is your feature request related to a problem? Please describe.

I want the processor to never redact specific values, such as email addresses from specific domains. For example, we need [email protected] to be redacted for compliance purposes, but not [email protected]

Describe the solution you'd like

Add an allowed_values configuration option that is a list of regexes (same as blocked_values), then never redact values that match at least one allowed_values regex (even if it also matches a blocked_values regex).

For example, with the given config:

processors:
  redaction:
    # ...
    blocked_values:
      - '.+@.+'
    allowed_values:
      - '[email protected]'

then [email protected] would be redacted in the relevant attributes, but [email protected] wouldn't.

Describe alternatives you've considered

The blocked_values uses Go's regexp package, which doesn't support negative lookahead, which could have been another alternative. There may be workarounds by incrementally excluding matches, but they result in very complex and hard to maintain matches

Additional context

I'm happy to contribute a PR if my proposed solution is acceptable

@janslow janslow added enhancement New feature or request needs triage New item requiring triage labels Oct 16, 2024
@github-actions github-actions bot added the processor/redaction Redaction processor label Oct 16, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage New item requiring triage processor/redaction Redaction processor
Projects
None yet
Development

No branches or pull requests

1 participant