[receiver/hostmetrics] should report scraper that failed in case of error

[pjanotti]

Component(s)

receiver/hostmetrics

Is your feature request related to a problem? Please describe.

In case of error the receiver/hostmetrics doesn't report which scraper failed, e.g.:

1729010081650,"2024-10-15T16:34:41.650Z	error	scraperhelper/scrapercontroller.go:205	Error scraping metrics	{""kind"": ""receiver"", ""name"": ""hostmetrics"", ""data_type"": ""metrics"", ""error"": ""failed to read usage at /boot/efi: no such file or directory"", ""scraper"": ""hostmetrics""}"
1729010081650,go.opentelemetry.io/collector/receiver/scraperhelper.(*controller).scrapeMetricsAndReport
1729010081650,	go.opentelemetry.io/collector/[email protected]/scraperhelper/scrapercontroller.go:205
1729010081650,go.opentelemetry.io/collector/receiver/scraperhelper.(*controller).startScraping.func1
1729010081650,	go.opentelemetry.io/collector/[email protected]/scraperhelper/scrapercontroller.go:181

Describe the solution you'd like

The error message should include the scraper name so the user can consider disabling it or changing some config setting.

Describe alternatives you've considered

No response

Additional context

No response

[github-actions]

Pinging code owners:

• receiver/hostmetrics: @dmitryax @braydonk

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[braydonk]

I'm not sure why, but all the scraper creation code uses hostmetrics (the type from the hostmetricsreceiver metadata package) rather than its own name. I'm not sure why it's done that way as it's before my time. @dmitryax any reason we shouldn't just adjust that code to use the respective scraper names instead of hostmetrics?

[dmitryax]

I agree. We should mention the scraper that failed