Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema and syntax #344

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Aug 8, 2024

We're moving schema file to the weaver project (as a part of #322 and open-telemetry/semantic-conventions#916).

This PR updates and cleans up schema definition and syntax docs:

  • migrate to the latest json-schema version
  • require stability on everything
  • remove prefix
  • remove allow_custom_values on enum attributes
  • allow deprecation on groups

Some of these properties were removed from build-tools code, others (like allow_custom_values) are still supported by the tooling.

Schema is not enforced: removing properties from the schema does not break anything, it will just improve VSCode autocomplete and highlight unknown properties in red.

TODO:

  • changelog

@lmolkova lmolkova requested review from a team August 8, 2024 04:39
@lmolkova lmolkova merged commit 15a0e83 into open-telemetry:main Aug 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants