Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stability required, fix ref and extends, render badges on metrics #272

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Feb 23, 2024

Follow up on #267 (comment)

See open-telemetry/semantic-conventions#763

This PR:

  • requires stability on attributes and metrics
  • allows to deprecate metrics
  • allows to render stability/deprecation labels on metrics
  • fixes stability and deprecation inheritance (there was no inheritance and according to semconvgen all attributes except their original definitions in the registry are experimental)

It would result in all metrics and attributes, referenced or declared to be able to have a badge (can turn on/off with cmd arg) - example with everything on:

Attribute Type Description Examples Requirement Level
test.deprecated_experimental_attr boolean Deprecated
Required
test.deprecated_stable_attr boolean Deprecated
Required
test.exp_attr boolean Experimental
Required
test.stable_attr boolean Stable
Required
Name Instrument Type Unit (UCUM) Description
stable_metric Histogram s Stable
stable_metric
Name Instrument Type Unit (UCUM) Description
experimental_metric Counter {e} Experimental
experimental_metric
Name Instrument Type Unit (UCUM) Description
deprecated_metric UpDownCounter {d} Deprecated
deprecated_metric

(PS: sorry for the huge PR, most of it is adding stability to all test data attributes 😴)

@lmolkova lmolkova requested review from a team February 23, 2024 07:08
semantic-conventions/syntax.md Show resolved Hide resolved
@arminru arminru merged commit 50add91 into open-telemetry:main Feb 27, 2024
4 checks passed
arminru added a commit to dynatrace-oss-contrib/build-tools that referenced this pull request Feb 27, 2024
arminru added a commit that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants