Creation of e2e test for favorite tasks #819

Angatupyry · 2023-10-26T18:38:58Z

What's new

e2e test for favorite task added

Self-checks

I have prototyped this new feature (if necessary) on Figma
I'm familiar with and follow this Typescript guideline
I added unit-tests for new components
I tried testing edge cases
I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Signed-off-by: Aaron Chong <[email protected]>

* Sent refresh counter app event to be void, introduced interval event Signed-off-by: Aaron Chong <[email protected]> * Fix prepend addition Signed-off-by: Aaron Chong <[email protected]> * Using 5 second periodic query interval Signed-off-by: Aaron Chong <[email protected]> * Refactor alert event to use void subject as well Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]>

Signed-off-by: Aaron Chong <[email protected]>

* Making form fields required Signed-off-by: Aaron Chong <[email protected]> * Basic checks for each task description to allow submission Signed-off-by: Aaron Chong <[email protected]> * Fix e2e tests, select coe for patrol explicitly Signed-off-by: Aaron Chong <[email protected]> * Splitting interface and refactoring validity check Signed-off-by: Aaron Chong <[email protected]> * Delivery quantity to positive int field, and sku to text field, monitor null or empty value Signed-off-by: Aaron Chong <[email protected]> * Disable submit when clean zone is removed Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]>

* Display an alert when low display res detected Signed-off-by: Aaron Chong <[email protected]> * Raising e2e test resolution Signed-off-by: Aaron Chong <[email protected]> * Adding comment about raising testing resolution Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]>

* Show month and day view Signed-off-by: Aaron Chong <[email protected]> * Turn off auto refresh when viewing schedule Signed-off-by: Aaron Chong <[email protected]> * Format date correctly to match with the frontend format Signed-off-by: angatupyry <[email protected]> * Auto refresh to be determined in the interval creation effect Signed-off-by: Aaron Chong <[email protected]> * Changing name to be explicit for panel Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> Signed-off-by: angatupyry <[email protected]> Co-authored-by: angatupyry <[email protected]>

* Create popup component to edit or delete events Signed-off-by: angatupyry <[email protected]> * Create popup component to edit or delete events Signed-off-by: angatupyry <[email protected]> * Adding popup to edit events Signed-off-by: angatupyry <[email protected]> * Enable or disable cells Signed-off-by: angatupyry <[email protected]> * Add schedule and openSchedulepopup props Signed-off-by: angatupyry <[email protected]> * Open create task form in edit event Signed-off-by: angatupyry <[email protected]> * Update entire schedule Signed-off-by: angatupyry <[email protected]> * Update entire schedule Signed-off-by: angatupyry <[email protected]> * Fix endpoint to receive task request Signed-off-by: angatupyry <[email protected]> * Remove unnecesary function and rename props Signed-off-by: angatupyry <[email protected]> * Create hooks to reuse function Signed-off-by: angatupyry <[email protected]> * Editing entire schedule Signed-off-by: angatupyry <[email protected]> * Using custom hook Signed-off-by: angatupyry <[email protected]> * Repeated functions sends to utils file Signed-off-by: angatupyry <[email protected]> * Create method to handle editing single event Signed-off-by: angatupyry <[email protected]> * Add utils file to be more cleaner Signed-off-by: angatupyry <[email protected]> * Setting on or never depending of the schedule value Signed-off-by: angatupyry <[email protected]> * Editing single event Signed-off-by: angatupyry <[email protected]> * Create a custom hook to get username Signed-off-by: angatupyry <[email protected]> * Use custom hook to get usernmae Signed-off-by: angatupyry <[email protected]> * Disabling cells without events Signed-off-by: angatupyry <[email protected]> * Add test for new component Signed-off-by: angatupyry <[email protected]> * Test created Signed-off-by: angatupyry <[email protected]> * Order status according to meaning and use ref instead of state to set the current event id Signed-off-by: angatupyry <[email protected]> * End of day using insted of end of minutes in until date Signed-off-by: angatupyry <[email protected]> * Set current state when click onSubmit button Signed-off-by: angatupyry <[email protected]> * Refresh events after sending submit and after close create task form Signed-off-by: angatupyry <[email protected]> * Fix bug editing entire events Signed-off-by: angatupyry <[email protected]> * Setting except dates as empty in editing mode Signed-off-by: angatupyry <[email protected]> * Separete scheduled component and tasks Signed-off-by: angatupyry <[email protected]> * Add explanation comment in new route Signed-off-by: angatupyry <[email protected]> * Default cursor in cells without events Signed-off-by: angatupyry <[email protected]> * Using the same terminology between edit and delete. Signed-off-by: angatupyry <[email protected]> * Rename file name to be more descriptive Signed-off-by: angatupyry <[email protected]> * Change name of Radio group Signed-off-by: angatupyry <[email protected]> * Move function from utils to task/utils since it is related to just tasks Signed-off-by: angatupyry <[email protected]> * Rename component name to be more descriptive Signed-off-by: angatupyry <[email protected]> * Fix test accoriing to changes on the component Signed-off-by: angatupyry <[email protected]> * Delete unnecesary props Signed-off-by: angatupyry <[email protected]> * Rename props to be more descriptive Signed-off-by: angatupyry <[email protected]> * Some minor changes to be more descriptive and clear Signed-off-by: angatupyry <[email protected]> * Make comments a little more descriptive, instead of pseudocode. Signed-off-by: angatupyry <[email protected]> * Add at time in schedule interface to set the time correctly Signed-off-by: angatupyry <[email protected]> --------- Signed-off-by: angatupyry <[email protected]>

…no callback (#776) Signed-off-by: Aaron Chong <[email protected]>

… runs the concurrently command (#779) Signed-off-by: Aaron Chong <[email protected]>

* Add rounds and join places in the short description function Signed-off-by: angatupyry <[email protected]> * Add [] between places Signed-off-by: angatupyry <[email protected]> --------- Signed-off-by: angatupyry <[email protected]>

* Support offline doc generation Signed-off-by: Aaron Chong <[email protected]> * Lint Signed-off-by: Aaron Chong <[email protected]> * Splitting static from run Signed-off-by: Aaron Chong <[email protected]> * psql config to use static as well Signed-off-by: Aaron Chong <[email protected]> * Change static to cache for cached files, serve bundle in static Signed-off-by: Aaron Chong <[email protected]> * Creating the cache directory just in case it is not called from pnpm Signed-off-by: Aaron Chong <[email protected]> * Moved bundle into package, fixed package_data invocation, use absolute path to bundles Signed-off-by: Aaron Chong <[email protected]> * Remove rogue print statement Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> (cherry picked from commit 828171e) Signed-off-by: Aaron Chong <[email protected]>

Support offline doc generation (#784)

* Fix editing single event setting the correct date Signed-off-by: angatupyry <[email protected]> * Add toIsoFormat Signed-off-by: angatupyry <[email protected]> * format date to isoFormat Signed-off-by: angatupyry <[email protected]> * Format to isoFormat Signed-off-by: angatupyry <[email protected]> * Revert to exceptDateref insted of the schedule request time Signed-off-by: angatupyry <[email protected]> --------- Signed-off-by: angatupyry <[email protected]>

* Detect 0 as number as well Signed-off-by: Aaron Chong <[email protected]> * Display error when fields are left empty during submit Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]>

* Add react three fiber and drei Signed-off-by: angatupyry <[email protected]> * Use component property in Box material ui component to avoid three Box component noise Signed-off-by: angatupyry <[email protected]> * Use component property in Box material ui component to avoid three Box component noise Signed-off-by: angatupyry <[email protected]> * Use component property in Box material ui component to avoid three Box component noise Signed-off-by: angatupyry <[email protected]> * Export function Signed-off-by: angatupyry <[email protected]> * Add wall draw calculation Signed-off-by: angatupyry <[email protected]> * Add reac three fiber logical Signed-off-by: angatupyry <[email protected]> * Migrate to react three fiber Signed-off-by: angatupyry <[email protected]> * Remove center state Signed-off-by: angatupyry <[email protected]> * Remove map setting Signed-off-by: angatupyry <[email protected]> * Make circle shape smaller Signed-off-by: angatupyry <[email protected]> * Add zindex to for the text layers to appear on top Signed-off-by: angatupyry <[email protected]> * Ensure that React doesn't attempt to create or update component Signed-off-by: angatupyry <[email protected]> * Add text rendering Signed-off-by: angatupyry <[email protected]> * Rendering labels Signed-off-by: angatupyry <[email protected]> * Hover and zoom text Signed-off-by: angatupyry <[email protected]> * Show labesl correctly Signed-off-by: angatupyry <[email protected]> * Remove unused imports Signed-off-by: angatupyry <[email protected]> * Implementing debounce to show labels with delay Signed-off-by: angatupyry <[email protected]> * Small fixes to react-three-fiber migration (#788) * Disable walls Signed-off-by: Aaron Chong <[email protected]> * Use useLoader with url only, catch CORS errors potentially due to timeout issues when images are large Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> * Add labels for elevator and door names Signed-off-by: angatupyry <[email protected]> * Wrap checkboxes into a div and use select to choose levels Signed-off-by: angatupyry <[email protected]> * Add zoom icon Signed-off-by: angatupyry <[email protected]> * Add levelselect event to persits between tabs Signed-off-by: angatupyry <[email protected]> * Using AppEvents to persits levels Signed-off-by: angatupyry <[email protected]> * Camera control component has been added Signed-off-by: angatupyry <[email protected]> * Zoom in and zoom out events Signed-off-by: angatupyry <[email protected]> * Add camera control component Signed-off-by: angatupyry <[email protected]> * Add a wheel function to test event Signed-off-by: angatupyry <[email protected]> * Expose debounce function Signed-off-by: angatupyry <[email protected]> * Add wheel function to get the zoom value Signed-off-by: angatupyry <[email protected]> * Updating zoom properly Signed-off-by: angatupyry <[email protected]> * Remove conditional useLoader Signed-off-by: angatupyry <[email protected]> * Remove zoom icon Signed-off-by: angatupyry <[email protected]> * Remove zoom implementation Signed-off-by: angatupyry <[email protected]> * Fix lint Signed-off-by: angatupyry <[email protected]> * Rewrite debounce functino Signed-off-by: angatupyry <[email protected]> * Add layers for pickup and dropoff waypoints Signed-off-by: angatupyry <[email protected]> * Fix dashboard CI for react-three-fiber migration (#795) * Set max heap size Signed-off-by: Aaron Chong <[email protected]> * Stop producing sourcemap for CI Signed-off-by: Aaron Chong <[email protected]> * max space to ci Signed-off-by: angatupyry <[email protected]> * Try build without sourcemap for CI, alongside heap size increment Signed-off-by: Aaron Chong <[email protected]> * Increasing heapsize on bootstrap step Signed-off-by: Aaron Chong <[email protected]> * Use experimental support for ECMAScript modules Signed-off-by: Aaron Chong <[email protected]> * Use react-components as a module instead Signed-off-by: Aaron Chong <[email protected]> * Remove use of meshes for robot icons Signed-off-by: Aaron Chong <[email protected]> * Revert module call Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> Signed-off-by: angatupyry <[email protected]> Co-authored-by: angatupyry <[email protected]> * Add spaces in layer names Signed-off-by: angatupyry <[email protected]> --------- Signed-off-by: angatupyry <[email protected]> Signed-off-by: Aaron Chong <[email protected]> Co-authored-by: Aaron Chong <[email protected]>

* Re-introduced and refactored zoom button implementation Signed-off-by: Aaron Chong <[email protected]> * Use IconButton, sizing props instead of sx, shuffle according to figma Signed-off-by: Aaron Chong <[email protected]> * Add handleScroll function to persits zoom between tabs (#801) Signed-off-by: angatupyry <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> Signed-off-by: angatupyry <[email protected]> Co-authored-by: César Rolón <[email protected]>

* Fix indexing of doors for entire building, minor refactor Signed-off-by: Aaron Chong <[email protected]> * Turn off sorting for unrelated columns, sort names by default for robot, doors and lifts Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]>

* Update camera position and save it in a Behaviour subject Signed-off-by: angatupyry <[email protected]> * Remove unused useEffect and state Signed-off-by: angatupyry <[email protected]> --------- Signed-off-by: angatupyry <[email protected]>

* Use gl element instead of window element Signed-off-by: angatupyry <[email protected]> * Remove console log Signed-off-by: angatupyry <[email protected]> --------- Signed-off-by: angatupyry <[email protected]>

Signed-off-by: Aaron Chong <[email protected]>

Signed-off-by: angatupyry <[email protected]>

codecov · 2023-10-26T18:49:38Z

Codecov Report

Merging #819 (15a9c62) into main (574de78) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #819      +/-   ##
==========================================
- Coverage   51.41%   51.38%   -0.03%     
==========================================
  Files         282      282              
  Lines        7140     7144       +4     
  Branches      960      961       +1     
==========================================
  Hits         3671     3671              
- Misses       3321     3325       +4     
  Partials      148      148

Flag	Coverage Δ
dashboard	`16.60% <ø> (ø)`
react-components	`49.81% <0.00%> (-0.11%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...kages/react-components/lib/confirmation-dialog.tsx	`83.33% <ø> (ø)`
...ackages/react-components/lib/tasks/create-task.tsx	`3.95% <0.00%> (-0.05%)`	⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

* Render image if robot icon exists Signed-off-by: angatupyry <[email protected]> * Add scale to robot resource Signed-off-by: angatupyry <[email protected]> * Using scale if exists in resource Signed-off-by: angatupyry <[email protected]> * Make waypoints transparent Signed-off-by: angatupyry <[email protected]> * Adjust text according to its length Signed-off-by: angatupyry <[email protected]> * Remove hasOwn property control Signed-off-by: angatupyry <[email protected]> --------- Signed-off-by: angatupyry <[email protected]>

aaronchongth

Thanks! Can we also test these scenarios

open create-task dialog again, clicking on the previously saved favorite task, the fields are populated properly
delete favorite task
stretch goal, fix [Bug]: Favorite tasks with same name is allowed #820, and make sure we can't submit with the same name

* Separate components to make it more testable Signed-off-by: angatupyry <[email protected]> * Create react three components tests Signed-off-by: angatupyry <[email protected]> * Add test for shape three rendering component Signed-off-by: angatupyry <[email protected]> * Create three fiber component test Signed-off-by: angatupyry <[email protected]> * Add test to layers controller Signed-off-by: angatupyry <[email protected]> * Add test id to the component Signed-off-by: angatupyry <[email protected]> * Install test-renderer in order to create test for three. Remove datatest id because it make app break Signed-off-by: angatupyry <[email protected]> * Fix spanish description Signed-off-by: angatupyry <[email protected]> * Change the way to import circle shape component Signed-off-by: angatupyry <[email protected]> * Fixing merge conflict Signed-off-by: angatupyry <[email protected]> --------- Signed-off-by: angatupyry <[email protected]>

* Fix the bug that keeps the robot in the opposite position to its task Signed-off-by: angatupyry <[email protected]> * Delete robot name from state if we can't get the current level Signed-off-by: angatupyry <[email protected]> * Check if robot location is available before attempting to render (#825) Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: angatupyry <[email protected]> Signed-off-by: Aaron Chong <[email protected]> Co-authored-by: Aaron Chong <[email protected]>

Signed-off-by: Aaron Chong <[email protected]>

Signed-off-by: angatupyry <[email protected]>

Signed-off-by: Aaron Chong <[email protected]>

aaronchongth

Thanks for setting this up! I've verified that it works locally, so I extended the timeout to 5 minutes to see if it is a latency issue on the side of the runner

aaronchongth and others added 22 commits August 31, 2023 12:32

Selecting a favorite task changes taskRequests, instead of append (#761)

274ca26

Signed-off-by: Aaron Chong <[email protected]>

Reverting to latest pnpm version when #6994 is fixed (#754)

3388e03

Signed-off-by: Aaron Chong <[email protected]>

Fixes prompt text, do not display ack button if not awknowledged and …

b04b8b6

…no callback (#776) Signed-off-by: Aaron Chong <[email protected]>

start:react builds dependencies before starting dashboard, start just…

34c69c5

… runs the concurrently command (#779) Signed-off-by: Aaron Chong <[email protected]>

Schedule event title (#782)

c1d78d2

* Add rounds and join places in the short description function Signed-off-by: angatupyry <[email protected]> * Add [] between places Signed-off-by: angatupyry <[email protected]> --------- Signed-off-by: angatupyry <[email protected]>

Merge pull request #786 from open-rmf/fix/split-cache-and-static

4e4e336

Support offline doc generation (#784)

Detect 0 as number as well (#793)

99ecd31

* Detect 0 as number as well Signed-off-by: Aaron Chong <[email protected]> * Display error when fields are left empty during submit Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]>

Fix wheel behavior (#805)

f722d64

* Use gl element instead of window element Signed-off-by: angatupyry <[email protected]> * Remove console log Signed-off-by: angatupyry <[email protected]> --------- Signed-off-by: angatupyry <[email protected]>

Fix oddly failing robot label and use same as other labels (#812)

59065b1

Signed-off-by: Aaron Chong <[email protected]>

Create e2e test to favorite task

e8ded63

Signed-off-by: angatupyry <[email protected]>

Fix lint error

4947372

Signed-off-by: angatupyry <[email protected]>

Angatupyry requested a review from aaronchongth October 26, 2023 18:54

aaronchongth requested changes Oct 30, 2023

View reviewed changes

Angatupyry and others added 4 commits November 1, 2023 01:47

Fix recursive call in effect (#826)

574de78

Signed-off-by: Aaron Chong <[email protected]>

Can't submit favorite task with the same name

5adca40

Signed-off-by: angatupyry <[email protected]>

Angatupyry added 2 commits November 9, 2023 11:03

Add test for duplicate favorite task name and delete favorite task

c1a6269

Signed-off-by: angatupyry <[email protected]>

Resolve merge conflict with main

9952c54

Signed-off-by: angatupyry <[email protected]>

Angatupyry requested a review from aaronchongth November 9, 2023 14:21

Create longer timeout to accommodate slower runner

15a9c62

Signed-off-by: Aaron Chong <[email protected]>

aaronchongth approved these changes Nov 12, 2023

View reviewed changes

aaronchongth force-pushed the main branch from 764c551 to 24a7189 Compare August 1, 2024 07:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Creation of e2e test for favorite tasks #819

Creation of e2e test for favorite tasks #819

Angatupyry commented Oct 26, 2023

codecov bot commented Oct 26, 2023 •

edited

Loading

aaronchongth left a comment

aaronchongth left a comment

Creation of e2e test for favorite tasks #819

Are you sure you want to change the base?

Creation of e2e test for favorite tasks #819

Conversation

Angatupyry commented Oct 26, 2023

What's new

Self-checks

Discussion

codecov bot commented Oct 26, 2023 • edited Loading

Codecov Report

aaronchongth left a comment

Choose a reason for hiding this comment

aaronchongth left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 26, 2023 •

edited

Loading