Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefixing capability to prrte binaries that will be used by Open MPI #10

Open
hppritcha opened this issue Jul 15, 2024 · 1 comment
Labels
capstone24 Issues to be worked on by capstone24 class

Comments

@hppritcha
Copy link
Member

hppritcha commented Jul 15, 2024

Some of the binaries currently created as part of the PRRTe build will still be needed by Open MPI. However, we don't want to have names which conflict with an external PRRTe installation.

The binaries that need to be renamed are

Rather than renaming the binaries, a better approach may be to use some kind of name prefixing mechanism. This would require enhancements to the PRRTE configury and Makefiles. There would also need to be c source code changes.

Ultimately we may wish to use a reduced set of tools, particularly for distributed virtual machine (DVM) management.

Note changes will need to be made to the Open MPI source code itself to so that its mpirun command continues to work. In particular ocurrences of prterun will need to be updated. Eventually these changes will be superseded by work done for issue open-mpi/ompi#12712.

To continue supporting singleton spawn within OMPI - which invokes ```pprte`` currently, the code in will need to be checked and possibly modified - ompi/dpm/dpm.c.

Renaming of prted will involve updating several places in the PRRTE PLM framework as well.

In addition to the binaries, the libprrte.so library installed as part of the build process should be prefixable as well. This will provide for additional protection for the renamed binaries not accidentally picking up an external libprrte.so at runtime. This rename should also change the soname of the library as well. This change is being tracked by issue #15 .

Ideally, the documentation pertaining to these binaries would also be updated to reflect the name changes resulting from the prefixing mechanism.

@rhc54
Copy link

rhc54 commented Jul 15, 2024

Technically, the only binaries you need for OMPI are prte (which is your mpirun) and prted. It would probably be a mistake for you to retain DVM operations in your fork as that will result in conflicts with true PRRTE installations.

prterun is just a symlink to prte, so if you update your mpirun to execute prte, you don't need to retain it.

Renaming these binaries is opening a giant can of worms - I would strongly advise against it.

@hppritcha hppritcha changed the title rename all prrte related binaries that will be used by Open MPI Add prefixing capability to prrte rbinaries and libraries that will be used by Open MPI Aug 21, 2024
@hppritcha hppritcha changed the title Add prefixing capability to prrte rbinaries and libraries that will be used by Open MPI Add prefixing capability to prrte binaries that will be used by Open MPI Aug 21, 2024
@hppritcha hppritcha added this to the Open MPI 6.0.x milestone Aug 21, 2024
@hppritcha hppritcha added capstone24 Issues to be worked on by capstone24 class and removed OMPI v6.0.x labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
capstone24 Issues to be worked on by capstone24 class
Projects
Development

No branches or pull requests

2 participants