Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix roi align symbolic function in onnx opset>=16 #2428

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

CescMessi
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The RoiAlign op parameters are different with ONNX document when opset>=16 in roi_align_default function, and the Squeeze op in this symbolic function is also wrong when the opset>=13. This PR fixed them.

Modification

Add judgment of opset version for Squeeze op, and change the RoiAlign op parameters when opset>=16.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2023

CLA assistant check
All committers have signed the CLA.

@RunningLeon RunningLeon added the bug Something isn't working label Sep 13, 2023
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage is 33.33% of modified lines.

Files Changed Coverage
mmdeploy/mmcv/ops/roi_align.py 33.33%

📢 Thoughts on this report? Let us know!.

@RunningLeon RunningLeon requested review from grimoire and removed request for grimoire September 14, 2023 03:10
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon merged commit ec35b40 into open-mmlab:main Sep 14, 2023
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants