Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update yolox-pose ut #2231

Merged
merged 3 commits into from
Jun 30, 2023
Merged

update yolox-pose ut #2231

merged 3 commits into from
Jun 30, 2023

Conversation

huayuan4396
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 21.66% and project coverage change: -0.26 ⚠️

Comparison is base (a664f06) 49.86% compared to head (6fb44cc) 49.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2231      +/-   ##
==========================================
- Coverage   49.86%   49.61%   -0.26%     
==========================================
  Files         340      341       +1     
  Lines       13024    13134     +110     
  Branches     1910     1927      +17     
==========================================
+ Hits         6495     6517      +22     
- Misses       6073     6157      +84     
- Partials      456      460       +4     
Flag Coverage Δ
unittests 49.61% <21.66%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdeploy/mmcv/ops/nms.py 58.80% <0.00%> (-1.95%) ⬇️
...loy/codebase/mmpose/deploy/pose_detection_model.py 55.64% <12.12%> (-16.70%) ⬇️
...oy/codebase/mmpose/models/heads/yolox_pose_head.py 20.63% <20.63%> (ø)
mmdeploy/codebase/mmpose/deploy/pose_detection.py 72.67% <66.66%> (+0.10%) ⬆️
mmdeploy/codebase/mmpose/models/heads/__init__.py 100.00% <100.00%> (ø)
mmdeploy/utils/constants.py 96.29% <100.00%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon merged commit df0bf8f into open-mmlab:main Jun 30, 2023
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants