-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Buttons not red in multiple places #7678
Comments
I personally think that any button that says "Delete" or "Remove" in it should be red. I'm thinking action buttons should have a fill color of red while dropdown buttons like the first photo should just be outlined in red |
if its the dropdown one, i agree it should be highlighted red, but at that point, it will look weird higlighted on the middle, so we should just put it in the bottom, i think every destruction action should be different color coded, and be the last option |
I agree, I'm going to make a test branch for this and play around with different variations and colors for buttons both action and dropdowns and I will attach photos of some concepts later, feel free to do the same! |
I think that every button that says "Delete" or "Remove" should be red, but I think if there is a dropdown "Delete" or "Remove" the font color should be red and so should the icon, rather than just highlighting the box red. |
These look good. Unrelated, but I am wondering why in the first screenshot, add members is a different color than add resources/add courses. |
That is a good point Jesse. @Mutugiii is this intentional or was it a mistake? |
I've attached a few instances where the delete buttons are not red. Although this is not a major issue, from a ui and ux perspective given that they are destructive actions they should be red and not accent colors which the user could possibly get confused with a different button
The text was updated successfully, but these errors were encountered: