Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: smoother settings (fixes #4445)(fixes #4448) #4446

Merged
merged 5 commits into from
Sep 20, 2024
Merged

sync: smoother settings (fixes #4445)(fixes #4448) #4446

merged 5 commits into from
Sep 20, 2024

Conversation

Okuro3499
Copy link
Collaborator

@Okuro3499 Okuro3499 commented Sep 20, 2024 •
edited
Loading

fixes #4445
synced.webm

roboscript autotest

web-build_20240920_fonw_panther-33-en_US-portrait_video.mp4

@deeppp15
Copy link
Member

  • Darkmode Clear Data Button not visible

image

@deeppp15 deeppp15 mentioned this pull request Sep 20, 2024
Closed
AdhamElAsfar99
AdhamElAsfar99 previously requested changes Sep 20, 2024
View reviewed changes
Copy link
Member

@AdhamElAsfar99 AdhamElAsfar99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cloud spinner text not visible in light mode

lightmode.sync.webm

@Okuro3499
Copy link
Collaborator Author

cloud spinner text not visible in light mode

lightmode.sync.webm

Screenshot_20240920_220136

@deeppp15
Copy link
Member

Fixes #4448

@deeppp15 deeppp15 changed the title sync: redesign setting dialog (fixes #4445) sync: redesign setting dialog (fixes #4445 #4448) Sep 20, 2024
@dogi dogi dismissed AdhamElAsfar99’s stale review September 20, 2024 19:40

thanks ... good catch

@dogi dogi changed the title sync: redesign setting dialog (fixes #4445 #4448) sync: smoother settings (fixes #4445)(fixes #4448) Sep 20, 2024
@dogi dogi merged commit 89c8101 into master Sep 20, 2024
2 checks passed
@Okuro3499 Okuro3499 deleted the 4445-sync-pop-up-redesign branch October 4, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deeppp15 deeppp15 deeppp15 approved these changes

@Kuljeet1998 Kuljeet1998 Kuljeet1998 approved these changes

@dogi dogi dogi approved these changes

@AdhamElAsfar99 AdhamElAsfar99 Awaiting requested review from AdhamElAsfar99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sync pop up redesign
5 participants
@Okuro3499 @deeppp15 @dogi @Kuljeet1998 @AdhamElAsfar99