Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Implement Logging Hook #299

Open
toddbaert opened this issue Sep 4, 2024 · 1 comment · May be fixed by #308
Open

[FEATURE] Implement Logging Hook #299

toddbaert opened this issue Sep 4, 2024 · 1 comment · May be fixed by #308
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@toddbaert
Copy link
Member

Requirements

Implement a logging hook as described in appendix A of the OpenFeaure spec: https://github.com/open-feature/spec/blob/main/specification/appendix-a-included-utilities.md#logging-hook
@toddbaert toddbaert added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 4, 2024
@kylejuliandev kylejuliandev linked a pull request Oct 4, 2024 that will close this issue
Draft
@kylejuliandev
Copy link

Hey @toddbaert,

I have an initial draft PR with some changes which I think address this issue. I think semantics on event numbers, log messages, and/or message formatting would need to be agreed.

I hope this is on the right track and would greatly appreciate any feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Implement Default Logging Hook kylejuliandev/dotnet-sdk
2 participants
@toddbaert @kylejuliandev