Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Api.Shutdown() hangs on reuse #186

Closed
austindrenski opened this issue Jan 17, 2024 · 1 comment · Fixed by #188
Closed

[BUG] Api.Shutdown() hangs on reuse #186

austindrenski opened this issue Jan 17, 2024 · 1 comment · Fixed by #188
Assignees
@austindrenski
Labels
bug Something isn't working

Comments

@austindrenski
Copy link
Member

austindrenski commented Jan 17, 2024 •
edited
Loading

Observed behavior

Stumbled onto this while investigating failing unit tests add as part of #181 that fail when run in concert, but pass when run independently.

Working theory is that we're not restarting the consumer thread. Patch forthcoming.

See: #181

Expected Behavior

No response

Steps to reproduce

No response
@austindrenski austindrenski added the bug Something isn't working label Jan 17, 2024
@austindrenski
Copy link
Member Author

Ah, okay, its blocking on the bounded channel inside of EventExecuter. Looking at a couple of options.

@austindrenski austindrenski mentioned this issue Jan 17, 2024
Merged
austindrenski added a commit to austindrenski/open-feature-dotnet-sdk that referenced this issue Jan 17, 2024
@austindrenski
fix: More robust shutdown/cleanup/reset
4c5d79f 
Previously, we shutdown the consumer thread causing any reuse of the
Api to block on the second event emitted to the event executor.

Fixes: open-feature#186

Signed-off-by: Austin Drenski <[email protected]>
@austindrenski austindrenski mentioned this issue Jan 17, 2024
Merged
austindrenski added a commit to austindrenski/open-feature-dotnet-sdk that referenced this issue Jan 17, 2024
@austindrenski
fix: More robust shutdown/cleanup/reset
2f17a64 
Previously, we shutdown the consumer thread causing any reuse of the
Api to block on the second event emitted to the event executor.

Fixes: open-feature#186

Signed-off-by: Austin Drenski <[email protected]>
austindrenski added a commit to austindrenski/open-feature-dotnet-sdk that referenced this issue Jan 17, 2024
@austindrenski
fix: More robust shutdown/cleanup/reset
66bf351 
Previously, we shutdown the consumer thread causing any reuse of the
Api to block on the second event emitted to the event executor.

Fixes: open-feature#186

Signed-off-by: Austin Drenski <[email protected]>
austindrenski added a commit to austindrenski/open-feature-dotnet-sdk that referenced this issue Jan 18, 2024
@austindrenski
fix: More robust shutdown/cleanup/reset
2c197d8 
Previously, we shutdown the consumer thread causing any reuse of the
Api to block on the second event emitted to the event executor.

Fixes: open-feature#186

Signed-off-by: Austin Drenski <[email protected]>
@austindrenski austindrenski self-assigned this Jan 18, 2024
@austindrenski austindrenski mentioned this issue Jan 18, 2024
Merged
austindrenski added a commit to austindrenski/open-feature-dotnet-sdk that referenced this issue Jan 19, 2024
@austindrenski
fix: More robust shutdown/cleanup/reset
f8ada7d 
Previously, we shutdown the consumer thread causing any reuse of the
Api to block on the second event emitted to the event executor.

Fixes: open-feature#186

Signed-off-by: Austin Drenski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@austindrenski austindrenski

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: More robust shutdown/cleanup/reset austindrenski/open-feature-dotnet-sdk
1 participant
@austindrenski