From 79def47106b19b316b691fa195f7160ddcfb9a41 Mon Sep 17 00:00:00 2001
From: Weihan Li <weihanli@outlook.com>
Date: Thu, 28 Mar 2024 08:03:21 +0800
Subject: [PATCH] chore(deps): Project file cleanup and remove unnecessary
 dependencies (#251)

## This PR

- simplify the `InternalsVisibleTo` usage
- cleanup msbuild condition
- remove unnecessary dependencies

---------

Signed-off-by: Weihan Li <weihanli@outlook.com>
Co-authored-by: Benjamin Evenson <2031163+benjiro@users.noreply.github.com>
---
 build/Common.props                 |  4 ++--
 src/OpenFeature/OpenFeature.csproj | 15 ++++-----------
 2 files changed, 6 insertions(+), 13 deletions(-)

diff --git a/build/Common.props b/build/Common.props
index 8468f7d2..b1857e0d 100644
--- a/build/Common.props
+++ b/build/Common.props
@@ -18,8 +18,8 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="System.Collections.Immutable" />
-    <PackageReference Include="System.Threading.Channels" />
+    <PackageReference Include="System.Collections.Immutable" Condition="'$(TargetFramework)' == 'net462' or '$(TargetFramework)' == 'netstandard2.0'" />
+    <PackageReference Include="System.Threading.Channels" Condition="'$(TargetFramework)' == 'net462' or '$(TargetFramework)' == 'netstandard2.0'" />
   </ItemGroup>
 
   <ItemGroup Condition="'$(OS)' == 'Unix'">
diff --git a/src/OpenFeature/OpenFeature.csproj b/src/OpenFeature/OpenFeature.csproj
index da82b999..9e272ba2 100644
--- a/src/OpenFeature/OpenFeature.csproj
+++ b/src/OpenFeature/OpenFeature.csproj
@@ -7,21 +7,14 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Condition="'$(TargetFramework)' == 'net462'" />
-    <PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Condition="'$(TargetFramework)' == 'netstandard2.0'" />
+    <PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Condition="'$(TargetFramework)' == 'net462' or '$(TargetFramework)' == 'netstandard2.0'" />
     <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
   </ItemGroup>
 
   <ItemGroup>
-    <AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
-      <_Parameter1>OpenFeature.Benchmarks</_Parameter1>
-    </AssemblyAttribute>
-    <AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
-      <_Parameter1>OpenFeature.Tests</_Parameter1>
-    </AssemblyAttribute>
-    <AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
-      <_Parameter1>OpenFeature.E2ETests</_Parameter1>
-    </AssemblyAttribute>
+    <InternalsVisibleTo Include="OpenFeature.Benchmarks" />
+    <InternalsVisibleTo Include="OpenFeature.Tests" />
+    <InternalsVisibleTo Include="OpenFeature.E2ETests" />
     <None Include="../../README.md" Pack="true" PackagePath="/" />
   </ItemGroup>