From 89425e0187fe07212d54158c67f8d2c64816837e Mon Sep 17 00:00:00 2001 From: Leymore Date: Mon, 22 Apr 2024 07:04:58 +0000 Subject: [PATCH] cherry pick from add-huggingface-above-v4.33, good TheoremQA results --- .../TheoremQA/TheoremQA_5shot_gen_6f0af8.py | 45 +++++++++++++++++++ .../TheoremQA/TheoremQA_few_shot_examples.py | 22 +++++++++ .../TheoremQA_few_shot_examples_official.py | 22 +++++++++ configs/datasets/TheoremQA/TheoremQA_gen.py | 2 +- .../{eval_theoremqa.py => eval_TheoremQA.py} | 11 ++--- opencompass/datasets/TheoremQA/main.py | 24 +++++++--- opencompass/datasets/TheoremQA/utils.py | 2 - 7 files changed, 114 insertions(+), 14 deletions(-) create mode 100644 configs/datasets/TheoremQA/TheoremQA_5shot_gen_6f0af8.py create mode 100644 configs/datasets/TheoremQA/TheoremQA_few_shot_examples.py create mode 100644 configs/datasets/TheoremQA/TheoremQA_few_shot_examples_official.py rename configs/{eval_theoremqa.py => eval_TheoremQA.py} (54%) diff --git a/configs/datasets/TheoremQA/TheoremQA_5shot_gen_6f0af8.py b/configs/datasets/TheoremQA/TheoremQA_5shot_gen_6f0af8.py new file mode 100644 index 000000000..bc7cae9f8 --- /dev/null +++ b/configs/datasets/TheoremQA/TheoremQA_5shot_gen_6f0af8.py @@ -0,0 +1,45 @@ +from mmengine.config import read_base +from opencompass.openicl.icl_prompt_template import PromptTemplate +from opencompass.openicl.icl_retriever import ZeroRetriever +from opencompass.openicl.icl_inferencer import GenInferencer +from opencompass.datasets import TheoremQADatasetV3, TheoremQA_postprocess_v3, TheoremQAEvaluatorV3 + +with read_base(): + from .TheoremQA_few_shot_examples import examples + +num_shot = 5 +rounds = [] +for index, (query, response) in enumerate(examples[:num_shot]): + if index == 0: + desc = "You are supposed to provide a solution to a given problem.\n\n" + else: + desc = "" + rounds += [ + dict(role="HUMAN", prompt=f"{desc}Problem:\n{query}\nSolution:"), + dict(role="BOT", prompt=f"{response}") + ] +rounds += [dict(role="HUMAN", prompt="Problem:\n{Question}\nSolution:")] + +TheoremQA_reader_cfg = dict(input_columns=["Question", "Answer_type"], output_column="Answer", train_split="test", test_split="test") + +TheoremQA_infer_cfg = dict( + prompt_template=dict(type=PromptTemplate, template=dict(round=rounds)), + retriever=dict(type=ZeroRetriever), + inferencer=dict(type=GenInferencer, max_out_len=1024, stopping_criteria=["Problem:", "Problem"]), +) + +TheoremQA_eval_cfg = dict( + evaluator=dict(type=TheoremQAEvaluatorV3), + pred_postprocessor=dict(type=TheoremQA_postprocess_v3) +) + +TheoremQA_datasets = [ + dict( + abbr="TheoremQA", + type=TheoremQADatasetV3, + path="data/TheoremQA/theoremqa_test.json", + reader_cfg=TheoremQA_reader_cfg, + infer_cfg=TheoremQA_infer_cfg, + eval_cfg=TheoremQA_eval_cfg, + ) +] diff --git a/configs/datasets/TheoremQA/TheoremQA_few_shot_examples.py b/configs/datasets/TheoremQA/TheoremQA_few_shot_examples.py new file mode 100644 index 000000000..578513d22 --- /dev/null +++ b/configs/datasets/TheoremQA/TheoremQA_few_shot_examples.py @@ -0,0 +1,22 @@ +examples = [ + ( + "In a 10 Gigabit Ethernet network, the average size of a frame is 1500 bytes. If a burst of noise lasting 1ms interrupts the network, how many frames are lost?", + "First, calculate the data rate in bytes/s:\n$$10 Gigabit/s * (1 Byte / 8 bits) = 1.25 * 10^9 Bytes/s$$\nNext, calculate the data loss in bytes due to the noise:\n$$1 ms * 1.25 * 10^9 Bytes/s = 1.25 * 10^6 Bytes$$\nFinally, divide the data loss by the average frame size to get the number of frames lost:\n$$1.25 * 10^6 Bytes / 1500 Bytes/frame \\approx 833.33 frames$$\nThe answer is 833.33", + ), + ( + "Given x = 0.157, what is the value of $x \\times \\frac{\\prod_{n=1}^\\infty (1 - \\frac{x^2}{n^2 \\pi^2})}{\\sin(x)}$?", + "To evaluate the expression $x \\times \\frac{\\prod_{n=1}^{\\infty} (1 - \\frac{x^2}{n^2 \\pi^2})}{\\sin(x)}$ given x = 0.157, we first recognize that the product in the numerator is related to the sine function through the Euler's reflection formula for the sine function, which can be expressed as:\n$$\\sin(x) = x \\prod_{n=1}^{\\infty} \\left(1 - \\frac{x^2}{n^2 \\pi^2}\\right)$$\nTherefore, the given expression simplifies to: $x \\times \\frac{\\sin(x)}{\\sin(x)}$\nBecause sin(x) in the numerator and denominator cancels out, the expression simplifies further to just x.\nSo, given x = 0.157, the value of the expression is 0.157. This result is derived from the properties of the sine function and does not require computational evaluation.\nThe answer is 0.157", + ), + ( + "Consider the basis C of $\\mathbb{R}^2$ consisting of vectors $u_1 = [2, 4]$ and $u_2 = [1, -1]$. If $y = [8, 12]$, find the C-coordinate vector of y.", + "The goal is to express y as a linear combination of the basis vectors of C, i.e., $y = a\\cdot u_1 + b\\cdot u_2$, where a and b are the scalar coefficients that we want to find. These coefficients will form the C-coordinate vector of y, which we'll denote as $[a, b]_C$.\nGiven:\n- $u_1 = [2, 4]$,\n- $u_2 = [1, -1]$,\n- $y = [8, 12]$.\nWe need to solve the system of linear equations:\n2a + 1b = 8\n4a - 1b = 12\nLet's solve this system of equations to find a and b.\nThe solution to the system of equations is $a = \\frac{10}{3} and b = \\frac{4}{3}$. Therefore, the C-coordinate vector of y in the basis consisting of vectors $u_1 = [2, 4]$ and $u_2 = [1, -1]$ is $\\left[\\frac{10}{3}, \\frac{4}{3}\\right]_C$.\nLet's calculate the numerical value of $\\left[\\frac{10}{3}, \\frac{4}{3}\\right]_C$ as [3.33, 1.33].\nThe answer is [3.33, 1.33]", + ), + ( + "One can draw a simple, connected planar graph with 200 vertices and 397 edges. Is this statement True or False?", + "To determine the answer, we can use Euler's formula for planar graphs, which states that for any finite, connected, planar graph, $V - E + F = 2$, where V is the number of vertices, E is the number of edges, and F is the number of faces.\nGiven the modified question, we have V = 200 vertices and E = 397 edges. We want to find if we can have a graph that satisfies these conditions, adhering to Euler's formula.\nFirst, let's rearrange Euler's formula to solve for F: F = E - V + 2\nSubstituting the given values: F = 397 - 200 + 2, F = 199\nThis means a graph with 200 vertices and 397 edges would have 199 faces. However, to determine the truth of this possibility, we should check if this graph doesn't violate any other planar graph constraints, particularly regarding the number of edges.\nFor a simple, connected planar graph, there's also a relationship between vertices, edges, and faces given by the inequality: $E \\leq 3V - 6$\nSubstituting V = 200 gives: $E \\leq 3*200 - 6 = 594$\nWith E = 397, the condition $E \\leq 594$ is satisfied, meaning it's theoretically possible in terms of the edge condition for a planar graph.\nTherefore, one can draw a simple, connected planar graph with 200 vertices and 397 edges, resulting in 199 faces, without violating the conditions for it to be planar according to both Euler's formula and the constraint on the maximum number of edges.\nThe answer is True", + ), + ( + "Given a finite group G, and a collection of permutations H on a set. Then (a) there always exists H such that G is isomorphic to H; (b) for any H, G is isomorphic to H; (c) G can never be isomorphic to H; (d) none of the above. Which option is correct?", + "This is based on Cayley's theorem, which states that every group G is isomorphic to a subgroup of the symmetric group acting on G.\nIn other words, for every finite group G, there exists a collection of permutations H (which in this context, can be thought of as the set of permutations representing the action of G on itself) such that G is isomorphic to H.\nTherefore, there always exists H such that G is isomorphic to H.\nThe answer is (a)", + ), +] diff --git a/configs/datasets/TheoremQA/TheoremQA_few_shot_examples_official.py b/configs/datasets/TheoremQA/TheoremQA_few_shot_examples_official.py new file mode 100644 index 000000000..618a65129 --- /dev/null +++ b/configs/datasets/TheoremQA/TheoremQA_few_shot_examples_official.py @@ -0,0 +1,22 @@ +examples = [ + ( + 'In a 10 Gigabit Ethernet network, the average size of a frame is 1500 bytes. If a burst of noise lasting 1ms interrupts the network, how many frames are lost?', + 'First, calculate the data rate in bytes/s:\n\n10 Gigabit/s * (1 Byte / 8 bits) = 1.25 * 10^9 Bytes/s\n\nNext, calculate the data loss in bytes due to the noise:\n\n1 ms * 1.25 * 10^9 Bytes/s = 1.25 * 10^6 Bytes\n\nFinally, divide the data loss by the average frame size to get the number of frames lost:\n\n1.25 * 10^6 Bytes / 1500 Bytes/frame ≈ 833.33 frames\nThe answer is 833.33' + ), + ( + 'Given x = 0.157, what is the value of x \\times \\frac{\\prod_{n=1}^\\infty (1 - \\frac{x^2}{n^2 \\pi^2})}{\\sin(x)}?', + "To evaluate the expression $x \\times \\frac{\\prod_{n=1}^{\\infty} (1 - \\frac{x^2}{n^2 \\pi^2})}{\\sin(x)}$ given x = 0.157, we first recognize that the product in the numerator is related to the sine function through the Euler's reflection formula for the sine function, which can be expressed as:\n\n$$\\sin(x) = x \\prod_{n=1}^{\\infty} \\left(1 - \\frac{x^2}{n^2 \\pi^2}\\right)$$\n\nTherefore, the given expression simplifies to: $x \\times \\frac{\\sin(x)}{\\sin(x)}$\n\nBecause sin(x) in the numerator and denominator cancels out, the expression simplifies further to just x.\n\nSo, given x = 0.157, the value of the expression is 0.157. This result is derived from the properties of the sine function and does not require computational evaluation.\nThe answer is 0.157" + ), + ( + 'Consider the basis C of \\mathbb{R}^2 consisting of vectors u_1 = [2, 4] and u_2 = [1, -1]. If y = [8, 12], find the C-coordinate vector of y.', + "The goal is to express y as a linear combination of the basis vectors of C, i.e., $y = a\\cdot u_1 + b\\cdot u_2$, where a and b are the scalar coefficients that we want to find. These coefficients will form the C-coordinate vector of y, which we'll denote as $[a, b]_C$.\n\nGiven:\n- $u_1 = [2, 4]$,\n- $u_2 = [1, -1]$,\n- $y = [8, 12]$.\n\nWe need to solve the system of linear equations:\n2a + 1b = 8\n4a - 1b = 12\n\nLet's solve this system of equations to find a and b.\n\nThe solution to the system of equations is $a = \\frac{10}{3} and b = \\frac{4}{3}$. Therefore, the C-coordinate vector of y in the basis consisting of vectors u_1 = [2, 4] and u_2 = [1, -1] is $\\left[\\frac{10}{3}, \\frac{4}{3}\\right]_C$. \nLet's calculate the numerical value of $\\left[\x0crac{10}{3}, \x0crac{4}{3}\right]_C$ as [3.33, 1.33].\nThe answer is [3.33, 1.33]" + ), + ( + 'One can draw a simple, connected planar graph with 200 vertices and 397 edges. Is this statement Trur or False?', + "To determine the answer, we can use Euler's formula for planar graphs, which states that for any finite, connected, planar graph, $V - E + F = 2$, where V is the number of vertices, E is the number of edges, and F is the number of faces.\n\nGiven the modified question, we have V = 200 vertices and E = 397 edges. We want to find if we can have a graph that satisfies these conditions, adhering to Euler's formula.\n\nFirst, let's rearrange Euler's formula to solve for F: F = E - V + 2\n\nSubstituting the given values: F = 397 - 200 + 2, F = 199\n\nThis means a graph with 200 vertices and 397 edges would have 199 faces. However, to determine the truth of this possibility, we should check if this graph doesn't violate any other planar graph constraints, particularly regarding the number of edges.\n\nFor a simple, connected planar graph, there's also a relationship between vertices, edges, and faces given by the inequality: $E \\leq 3V - 6$\n\nSubstituting V = 200 gives: $E \\leq 3*200 - 6 = 594$\n\nWith E = 397, the condition $E \\leq 594$ is satisfied, meaning it's theoretically possible in terms of the edge condition for a planar graph.\n\nTherefore, one can draw a simple, connected planar graph with 200 vertices and 397 edges, resulting in 199 faces, without violating the conditions for it to be planar according to both Euler's formula and the constraint on the maximum number of edges.\nThe answer is True" + ), + ( + 'Given a finite group G, and a collection of permutations H on a set. Then (a) there always exists H such that G is isomorphic to H; (b) for any H, G is isomorphic to H; (c) G can never be isomorphic to H; (d) none of the above. Which option is correct?', + "This is based on Cayley's theorem, which states that every group G is isomorphic to a subgroup of the symmetric group acting on G. \nIn other words, for every finite group G, there exists a collection of permutations H (which in this context, can be thought of as the set of permutations representing the action of G on itself) such that G is isomorphic to H.\n\nTherefore, there always exists H such that G is isomorphic to H.\nThe answer is (a)" + ) +] diff --git a/configs/datasets/TheoremQA/TheoremQA_gen.py b/configs/datasets/TheoremQA/TheoremQA_gen.py index 0824a9c20..acf8a3b07 100644 --- a/configs/datasets/TheoremQA/TheoremQA_gen.py +++ b/configs/datasets/TheoremQA/TheoremQA_gen.py @@ -1,4 +1,4 @@ from mmengine.config import read_base with read_base(): - from .TheoremQA_gen_7009de import TheoremQA_datasets # noqa: F401, F403 + from .TheoremQA_5shot_gen_6f0af8 import TheoremQA_datasets # noqa: F401, F403 diff --git a/configs/eval_theoremqa.py b/configs/eval_TheoremQA.py similarity index 54% rename from configs/eval_theoremqa.py rename to configs/eval_TheoremQA.py index 4f37d5488..818eaacd9 100644 --- a/configs/eval_theoremqa.py +++ b/configs/eval_TheoremQA.py @@ -4,14 +4,15 @@ from .models.mistral.hf_mistral_7b_v0_1 import models as hf_mistral_7b_v0_1_model from .models.mistral.hf_mistral_7b_v0_2 import models as hf_mistral_7b_v0_2_model from .models.hf_internlm.hf_internlm2_20b import models as hf_internlm2_20b_model + from .models.hf_internlm.hf_internlm2_math_20b import models as hf_internlm2_math_20b_model - from .datasets.TheoremQA.TheoremQA_5shot_gen_a4f581 import TheoremQA_datasets as datasets + from .datasets.TheoremQA.TheoremQA_5shot_gen_6f0af8 import TheoremQA_datasets as datasets models = sum([v for k, v in locals().items() if k.endswith("_model")], []) -work_dir = 'outputs/debug/theorem-5shot' +work_dir = 'outputs/TheoremQA-5shot' -# dataset version metric mode mistral-7b-v0.1-hf mistral-7b-v0.2-hf internlm2-20b-hf -# --------- --------- -------- ------ -------------------- -------------------- ------------------ -# TheoremQA a4f581 score gen 11.5 10.25 19.25 +# dataset version metric mode mistral-7b-v0.1-hf mistral-7b-v0.2-hf internlm2-20b-hf internlm2-math-20b-hf +# --------- --------- -------- ------ -------------------- -------------------- ------------------ ----------------------- +# TheoremQA 6f0af8 score gen 18.00 16.75 25.87 30.88 diff --git a/opencompass/datasets/TheoremQA/main.py b/opencompass/datasets/TheoremQA/main.py index 7973c7559..9e574ddd8 100644 --- a/opencompass/datasets/TheoremQA/main.py +++ b/opencompass/datasets/TheoremQA/main.py @@ -1,6 +1,7 @@ import re +import json -from datasets import load_dataset +from datasets import Dataset, DatasetDict from opencompass.registry import LOAD_DATASET, TEXT_POSTPROCESSORS, ICL_EVALUATORS @@ -12,9 +13,15 @@ @LOAD_DATASET.register_module() class TheoremQADatasetV3(BaseDataset): + @staticmethod def load(path: str): - return load_dataset("csv", data_files={"test": path}) + with open(path, 'r') as f: + data = json.load(f) + for item in data: + item['Answer'] = str(item['Answer']) + dataset = Dataset.from_list(data) + return dataset def TheoremQA_postprocess_v3(text: str) -> str: @@ -24,15 +31,20 @@ def TheoremQA_postprocess_v3(text: str) -> str: @ICL_EVALUATORS.register_module() class TheoremQAEvaluatorV3(BaseEvaluator): - def score(self, predictions, references): + def score(self, predictions, references, test_set): if len(predictions) != len(references): return {"error": "preds and refrs have different length"} details = [] correct, wrong = 0, 0 - for answer, groundtruth in zip(tqdm(predictions), references): - if isinstance(groundtruth, str): - groundtruth = [groundtruth] + for index in tqdm(range(len(predictions))): + answer = predictions[index] + groundtruth = references[index] + answer_type = test_set[index]['Answer_type'] + if answer_type in ['float', 'integer', 'bool']: + groundtruth = [groundtruth, eval(groundtruth)] + else: + groundtruth = [groundtruth, None] if utils.compare_answer_with_groundtruth(answer, *groundtruth): correct += 1 is_correct = True diff --git a/opencompass/datasets/TheoremQA/utils.py b/opencompass/datasets/TheoremQA/utils.py index 420e64209..a4f32b2ba 100644 --- a/opencompass/datasets/TheoremQA/utils.py +++ b/opencompass/datasets/TheoremQA/utils.py @@ -84,8 +84,6 @@ def answer_clean(direct_answer_trigger_for_fewshot: tuple, pred: str): # Remove the period at the end, again! pred = pred.rstrip('.').rstrip('/') - print(pred) - return pred