Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Download file naming dialog Cancel button prone to false trigger on longpress-release #76

Open
badger200 opened this issue May 30, 2021 · 2 comments

Comments

@badger200
Copy link

badger200 commented May 30, 2021

This bug has existed for over a year and finally annoyed me enough to report.

Repro scenario:

  1. Open video full screen in Safari.
  2. Tap Download button in upper left corner ⭕️⬇️
  3. Choose a folder that will pop up the file naming dialog.
  4. Long press filename text to trigger iOS magnifying lens cursor-moving feature, drag left to beginning of filename. I usually want to name a file something like “(Default) 1a Apple Banana Coconut.mp4”, so I’m trying to insert the “1a” after the first default word.
  5. Notice that VERY OFTEN, the mere moving of the text cursor, somehow incorrectly results in firing a “Cancel button tap” which never happens in any other app, because the Text-select-cursor-magnifying feature is always “on top” and thus, it should never simultaneously trigger taps on elements beneath it.

In other words, if you drag your text cursor selection to the left and release it over the Cancel button (or seemingly, even anywhere near it..), this triggers the Cancel and you lose the entire filename you just carefully typed out.

PROPOSED SOLUTIONS:
A. Fix Cancel button so it does not fire when it’s not truly on Top of UI Z-order (as during a long press text field cursor drag-movement.)
B. Move Cancel button further away from text field, perhaps inserting some vertical height via extra horizontal separator lines between textfield and buttons beneath.
C. Add customizable auto-filenaming feature. Because I often download multiple videos from the same site and the default suggestion is worthless because it will always fail due to existing file. It would be so helpful to auto increment subsequent filenames like “1...2...3...4 etc”. I almost NEVER have a scenario where I would want the operation to be canceled due to an existing video with the default filename!

Devices:
iPad Pro 9.7”
iOS 12.4
Uncover 6.1.2
Latest Safari Plus

iPhone 6S
iOS 13.3
Uncover 6.1.2
Latest Safari plus

@opa334
Copy link
Owner

opa334 commented May 31, 2021

If this issue is just that it is possible to both move the text cursor and press a button in the alert at the same time, then it's not really fixable cause that's just how iOS behaves (and it's also not really feasable to modify the stock alert view).

Auto-filenaming is something I may look into in the future.

@badger200
Copy link
Author

badger200 commented Jun 6, 2021

Hmm that's tricky.. I have never experienced this issue in any other app and your dialog is pretty standard, so it seems very likely to me there's something unusual going on here.. Or else I would be routinely accidentally cancelling file naming in other apps.

I'm not so sure this is just how iOS behaves. Try dragging the text cursor and releasing over buttons in other apps. I can't get it to trigger anywhere except this SafariPlus download field. I just tried it on this iOS GitHub app as I'm typing this (I released over Bold and it did not trigger the Bold button).

Great to hear about the auto generated filenames.

I can't live without this tweak and can't thank you enough for writing it. I'm an r/DataHoarder (new term I just discovered).

I'm pretty sure I use other tweaks of yours, I will look for a donate to send you a PayPal 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants