-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDPClient.prototype.call parameter confusion #69
Comments
Hi, your observation is correct regarding the parameters of So all dependent packages that use the As I said above, I agree that the incongruity here is unfortunate, but this package has a fairly long list of dependents. As such, I would argue that this ship has sailed, so to speak, and we should just live with it, at least until some more pressing breaking changes are warranted, necessitating a full 1.0 semver major release. IMO, this is a nicety, but not worth all of the fuss it seems likely to cause. |
@vsivsi I see your point, but that would just be an easy fix:
In my experience, when developers are upgrading code, as long as you dont just change the API completely without a fair warning, they are ok with it. I can add all the backward compatibility to my PR.. |
In JS
function.call
expects parameters to be passed in directly instead of an array of parameters...Also,
Meteor.call
accepts direct parameters whileMeteor.apply
accepts an arrayThe proposal:
Change from:
DDPClient.prototype.call
andDDPClient.prototype.callWithRandomSeed
to:
DDPClient.prototype.send
andDDPClient.prototype.sendWithRandomSeed
The text was updated successfully, but these errors were encountered: