Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ooniauth): fix NoneType error while running tests #857

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

DecFox
Copy link
Contributor

@DecFox DecFox commented Jul 8, 2024

The CI seems to be failing here: https://github.com/ooni/backend/actions/runs/9806850337/job/27079418730. This should fix the error by accounting for the Nonetype check while fetching fields from the client token by wrapping in a try-except block. Closes #858

@DecFox DecFox requested a review from hellais July 8, 2024 21:42
Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DecFox DecFox merged commit 578d8ad into master Jul 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI fails for ooniauth
3 participants