Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nest oonirun-links into oonirun/links #826

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Nest oonirun-links into oonirun/links #826

merged 2 commits into from
Mar 15, 2024

Conversation

hellais
Copy link
Member

@hellais hellais commented Mar 15, 2024

It's easier to apply routing glob matches if each service is nested in a way that's predictable, such as:

  • /api/v2/<service_name>/<resources>

For example

  • /api/v2/oonirun/links
  • /api/v2/ooniauth/user-session
    etc.

@hellais hellais requested a review from majakomel March 15, 2024 10:19
@hellais hellais merged commit e486936 into master Mar 15, 2024
4 checks passed
@hellais hellais deleted the oonirun-nested branch March 15, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants