Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production grade http.Client #2

Open
meson10 opened this issue May 8, 2018 · 0 comments
Open

Production grade http.Client #2

meson10 opened this issue May 8, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@meson10
Copy link
Contributor

meson10 commented May 8, 2018

I see that you use vanilla http.Client{}, which is marred with problems when used in production workloads. Illustrated here: https://medium.com/@nate510/don-t-use-go-s-default-http-client-4804cb19f779

Would recommend you to make some changes like Timeout etc.

@meson10 meson10 added the enhancement New feature or request label May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants