ci.md

Ignition Continuous Integration

When developers push code changes into Ignition, a series of automated tests run for various platforms. This process is called Continuous Integration, or CI. This document covers all the CI jobs that are available for Ignition and how to interpret their results.

This documentation assumes you have gone over the Contributing guide and therefore are familiar with:

• Opening pull requests
• Automated tests
• Test coverage
• Static code checking
• Branching (stable release branches and main)
• Building with cmake or colcon
• Developer Certificate of Origin (DCO) check

It's also helpful to go over our Release guide to be familiar with:

• Supported platforms
• Stable, pre-release and nightly releases
• Binary releases like Debian

Types of checks

The main type of check that is performed by CI is compiling the code and running all automated tests. Some jobs may also run static checkers, add labels, check DCO and code coverage.

All checks are visible at the bottom of a pull request, for example:

We use two platforms to run CI (Jenkins and GitHub Actions), each of them running different builds.

Our Jenkins server is located at https://build.osrfoundation.org/. It runs builds for all supported operating systems. It also runs an ABI checker for all stable branches.

GitHub actions run on GitHub's servers. Currently, it builds Linux for all libraries, and macOS for some of them.

Here's a summary of all checks.

Platform	Job name	OS	What does it do?	Where dependencies come from?
Jenkins	<library>-ci-pr_any-ubuntu-auto-amd64	Ubuntu	Compile and run tests using CMake and Make	Stable binaries for stable branches, nightlies for main
Jenkins	<library>-ci-pr_any-homebrew-amd64	macOS	Compile and run tests using CMake and Make	Homebrew binaries bottled from osrf/simulation tap
Jenkins	<library>-ci-pr_any-windows*-amd64	Windows (deprecated)	Compile and run tests using configure.bat scripts and CMake + Visual Studio directly	External dependencies from custom tarballs
Jenkins	<library>-pr-win	Windows	Compile and run tests using colcon	External dependencies from vcpkg, Ignition dependencies built from source with colcon
Jenkins	<library>-abichecker-any_to_any-ubuntu_auto-amd64	Ubuntu	Run ABI checker	Stable binaries
Actions	Ubuntu CI / Ubuntu * CI	Ubuntu Bionic and Focal	Compile and run tests using CMake and Make, run code checker and upload coverage results	Stable binaries for stable branches, nightlies for main
Actions	DCO	-	Checks that all commits are signed correctly	-
Actions	PR Collection Labeler	-	Adds collection labels (i.e. Blueprint, Citadel...) according to the target branch	-
Actions	Ticket opened	-	Adds the pull request to the Core development board	-
Actions	codecov/*	-	Checks that the test coverage hasn't been reduced	-

Notes:

• The ABI job isn't triggered for the main branch, because that's where it's ok to break ABI.
• GitHub Actions jobs can have the pull_request or push suffix:
  • pull_request: Runs when a pull request is open and subsequent pushes are made to it.
  • push: Runs for every commit pushed to the official repository. These don't run for forks. Pull requests from the official repository will have both push and pull_request.
• Only the Bionic Action uploads coverage results to Codecov, so we have a single coverage result for each branch.
• There's some overlap between Jenkins and Actions jobs for Ubuntu, but they have some differences. Some Jenkins jobs run with on GPU machines and provides a nice interface to introspect builds. On the other hand, Actions runs coverage and codecheck.
• The choice of stable / pre-release / nightly dependencies for Linux CI on both Jenkins and Actions is defined on gzdev's repository.yaml

Required checks

Some checks are marked as Required. This means the pull request can't be merged unless that check is green.

Ideally, all checks would be required. But known warnings, test failures and flaky tests often prevent us from marking them as required, otherwise no pull requests could be merged. Until these are addressed, some checks will need to be checked by hand when they fail, to see if those failures are unexpected. See this issue for what checks are required for each library.

Interpreting results

On the GitHub UI, checks can be:

• ✅: Passed, all good!
• 🟡: Pending, results haven't been received yet.
• ❌: Failed, something is wrong.

Depending on the library and on the build queue (from our Jenkins server), checks can be in a pending 🟡 state from a couple of minutes up to an entire day. If a build is in this state for too long, there may be some issue with infrastructure and the build didn't run or didn't report back.

Failing builds ❌ usually require more investigation:

• If the build is Required, something is definitely wrong and must be fixed before merging the pull request.
• If the build is not required, investigation is needed to find out if the failure is pre-existing or if it is being introduced by the pull request.

Clicking on the Details button of a failing build takes you to the build so that you can inspect it.

Builds can fail for a variety of reasons, for example:

• The code failed to compile. This should never be accepted, even in non-required checks, and must be fixed.
  • Jenkins: When there's a compilation failure, the build is marked red 🔴. On the build's page, click on Console Output then scroll until you find the compilation errors under the compiling section.
  • Actions: When there's a compilation failure, the build is marked red ❌. On the build logs, the compilation failure should be under the make collapsible.
• There are test failures. Test failures that aren't pre-existing must be fixed.
  • Jenkins: When there are test failures, the build is marked yellow 🟡. On the build's page, the failing tests are listed under Test Result. Click on a test's name, then on "History" on the left to see if the test has failed before. It's often helpful to see the full test logs on Console Output.
  • Actions: When there are test failures, the build is marked red ❌. On the build logs, the test failures should be under the make test collapsible.
  • Check which tests are known failures by searching for the test name on issues.
• There are warnings. Warnings that aren't pre-existing must be fixed.
  • Jenkins: When there are warnings, the build is marked yellow 🟡. On the build's page, the warnings are listed under GNU C Compiler and CMake. You can also check the Console Output for the full warning logs.
  • Actions: Does not detect compiler or CMake warnings.
• There are static checker failures. All code checker failures must be fixed.
  • Jenkins: Does not run static checkers.
  • Actions: When there are code check failures, the build is marked red ❌. On the build logs, the checker failures should be under the Code check collapsible.
• There are infrastructure failures. Contributors should leave a comment on the pull request for maintainers, who will report these to the build farmer.
  • Jenkins: When there's an infra failure, the build is marked red 🔴. These can manifest in various ways. In general, if the build logs don't fall in the categories above, there's a high chance it's an infrastructure failure. Common patterns usually have several java or hudson messages.
  • Actions: Infrastructure failures haven't been identified.

Triggering CI

CI is usually triggered automatically when code is pushed or a pull request is opened. But often it's necessary to re-trigger CI without making changes to the code if:

• There were infrastructure failures in a previous build.
• There are fixes upstream, on infra or dependencies, that may make a new build pass.

The following methods can be used by maintainers to re-trigger builds:

• Jenkins
  • Make a comment starting with @osrf-jenkins run tests on the pull request and all Jenkins builds will be re-triggered.
  • To restart just one specific build and avoid re-running builds that aren't necessary, go to the failing build and click Retry in the Jenkins UI after login.
• Actions
  • On the top-right of a build inside the 'Actions' tab of GitHub, click Re-run jobs. Note that this button sometimes mysteriously disappears.

Custom branches

Maintainers can manually trigger builds for custom branches without opening pull requests, optionally building dependencies from source and changing other configurations for testing.

One possible reason to trigger CI with custom dependency branches is testing changes across repositories. For example, if your ign-gazebo pull request needs a change from ign-physics, you could build a custom branch of ign-physics from source to check it works with ign-gazebo on CI before even opening an ign-physics pull request, or making a release.

Actions

By default, builds are run for every commit based on configuration inside the .github/ci directory. So it's possible to change the contents of that directory and immediately see updated CI results when you push commits.

See the documentation on action-ignition-ci to see what can be configured and how.

Be sure to revert these changes before merging the pull request.

Jenkins

The pr_any jobs can be triggered manually for any branch by maintainers. Go to the job's page, for example ignition_launch-ci-pr_any-ubuntu_auto-amd64, click on Build with Parameters to trigger a new build (beware of this issue and use this carefully).

There are 2 things you'll want to configure before triggering a build:

• sha1: this is the custom branch you want to build, prefixed by origin/.
• RTOOLS_BRANCH: a branch in release-tools that contains custom configuration. For example, see this change for building a custom ign-rendering branch on this ign-sensors pull request.

If you want to share the status of your custom build on a pull request, click on Embeddable Build Status and copy the markdown code into the pull request.

Development

All the infrastructure for our CI is in the ignition-tooling organization.

• Most of the stuff running in Jenkins is in release-tools.
• The GitHub action is in action-ignition-ci.