Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serializeDateTimeNorm -> serializeDateTimeNormWithTZ #1

Open
stefanbischof opened this issue Feb 23, 2024 · 1 comment
Open

serializeDateTimeNorm -> serializeDateTimeNormWithTZ #1

stefanbischof opened this issue Feb 23, 2024 · 1 comment

Comments

@stefanbischof
Copy link

The method serializeDateTimeNorm is no longer an abstract method of AbstractSQLDBFunctionSymbolFactory, instead there is the method serializeDateTimeNormWithTZ which has to be overridden. Is there anything else needed besides changing the method name and TODO-SCAFFOLD comment?

protected String serializeDateTimeNorm(ImmutableList<? extends ImmutableTerm> terms, Function<ImmutableTerm, String> termConverter, TermFactory termFactory) {

@bcogrel
Copy link
Member

bcogrel commented Feb 23, 2024

Hi @stefanbischof, thanks for pointing it. Yes, that's should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants