Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROBOT reduce does not reduce subclasses between names by default #956

Open
matentzn opened this issue Dec 17, 2021 · 3 comments
Open

ROBOT reduce does not reduce subclasses between names by default #956

matentzn opened this issue Dec 17, 2021 · 3 comments
Assignees

Comments

@matentzn
Copy link
Contributor

Currently:

robot reduce -i o.ofn  -o reduced.ofn

Does not reduce A = B, A Sub B , B Sub A to A = B (where A and B are names).

Only this does:

robot reduce -i o.ofn --named-classes-only true -o reduced.ofn

@cmungall if this is intended, we should clarify this in the docs

@cmungall
Copy link
Contributor

The docs are indeed confusing here:

Reciprocal subclass axioms (e.g. A SubClassOf B, B SubClassOf A), entailing equivalence between A and B, may be removed by reduce. In this case it is important to assert an equivalence axiom (A EquivalentTo B) using the reason command before running reduce.

The "may" here is not helpful, as is the asymmetry between the two algorithms (NC only vs anonymous).

Leave this assigned to me and I will fix. There are some java docstrings that could be elevated up to the markdown.

Note there is a more detailed treatment of redundancy/transitive reduction here: INCATools/relation-graph#63

@cmungall
Copy link
Contributor

I think this is resolved now?

@matentzn
Copy link
Contributor Author

I am not sure at all! I have not fixed this issue if it existed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants