Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sign to idempotent ops list #139

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add sign to idempotent ops list #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4db367
Add sign to idempotent ops list
ananyamukh6 Aug 18, 2023
d674903
flake8
ananyamukh6 Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion onnxoptimizer/passes/eliminate_consecutive_idempotent_ops.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ struct EliminateConsecutiveIdempotentOps final : public PredicateBasedPass {

bool patternMatchPredicate(Node* node) override {
static const std::unordered_set<std::string> idempotent_ops = {
"Ceil", "Floor", "Round", "Relu", "Reshape"};
"Ceil", "Floor", "Round", "Relu", "Reshape", "Sign"};
for (const auto& op : idempotent_ops) {
// TODO: support uses().size() > 1 for ops except Reshape
if (CheckKind(node, Symbol(op), 0, Symbol(op)) &&
Expand Down
20 changes: 20 additions & 0 deletions onnxoptimizer/test/optimizer_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4597,6 +4597,26 @@ def test_eliminate_consecutive_idempotent_op(self):
assert optimized_model.graph.node[0].op_type == "Constant"
assert optimized_model.graph.node[1].op_type == "Reshape"

def test_eliminate_consecutive_idempotent_sign_op(self):
model = parser.parse_model("""
<
ir_version: 7,
opset_import:["": 11]
>
agraph (float[1, 2, 3] X) => (float[1, 2, 3] Z)
{
T1 = Sign(X)
T2 = Sign(T1)
T3 = Sign(T2)
Z = Sign(T3)
}
""")

optimized_model = self._optimized(
model, ['eliminate_consecutive_idempotent_ops', 'eliminate_deadend'], True)
assert len(optimized_model.graph.node) == 1
assert optimized_model.graph.node[0].op_type == "Sign"


if __name__ == "__main__":
unittest.main()