Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sign to idempotent ops list #139

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ananyamukh6
Copy link

Sign op is idempotent, so adding it to eliminate_consecutive_idempotent_ops pass

@daquexian
Copy link
Member

LGTM, thanks!

@ananyamukh6
Copy link
Author

@daquexian , the tests seemsed to have failed because of flake8. I pused a patch fixing the flake8 errors. Is there any other style checks to be run (like say for the cpp code)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants