Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eval): Add callback to listen to let expression #244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Nov 6, 2020

The idea would be that the libvim consumer could listen for let mapleader="<space>" or similar expressions, which is needed since input mapping is externalizd.

bryphe added a commit to onivim/oni2 that referenced this pull request Nov 7, 2020
This adds support for specifying the `<leader>` key in `keybindings.json` as well as mappings coming from VimL (`map` family).

The leader key can be specified via either:
- `vim.leader` configuration setting in `configuration.json` - ie: `"vim.leader": "<space>"`
- `:map <space> <leader>`"` via an Ex command.

In addition, this also lays some groundwork for some other binding constructs we need... Like support for handling `<Plug>` and `<SNR>` as part of the VimL integration work.

__TODO:__ 
- [x] Depends on #2668 
- [x] Add `vim.leader` configuration setting
- [x] Update documentation

__Next steps:__
- Pull leader key from `let mapleader`, if available - this requires a bit of extra work in libvim: onivim/libvim#244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant