[F-Droid Nightly Repo] IndexV1 has faulty field(s)

[machiav3lli]

https://raw.githubusercontent.com/onionshare/onionshare-android-nightly/master/fdroid/repo/index-v1.json

The published JAR/JSON for the nightly repo seems to mix IndexV1 with IndexV2 Schemas. More specifically repo.mirrors seems to be a array of objects (which is true for IndexV2) instead of strings.

"mirrors": [{"isPrimary": true, "url": "https://raw.githubusercontent.com/onionshare/onionshare-android-nightly/master/fdroid/repo"}]

Expected:

"mirrors": ["https://raw.githubusercontent.com/onionshare/onionshare-android-nightly/master/fdroid/repo"]

[eighthave]

Looks like a bug in fdroidserver, which version of fdroidserver was used to generate this?

[eighthave]

I'm not seeing this in other repos:

• https://guardianproject.info/fdroid/repo/index-v1.json
• https://gitlab.com/fdroid/fdroidclient-nightly/-/blob/master/fdroid/repo/index-v1.json?ref_type=heads

So I'm guessing you're running on old version of fdroidserver

[grote]

This uses fdroid/docker-executable-fdroidserver:latest which pulls in master branch of fdroidserver: https://gitlab.com/fdroid/docker-executable-fdroidserver/-/blob/fa8033e738261b976d1c0e7839152fe0f1ee839c/Dockerfile#L8

[grote]

@eighthave I rebuilt fdroid/docker-executable-fdroidserver:latest and ran the nightly publish again. Same result.

I don't know how you build the guardianproject repo, but fdroidclient-nightly is built with fdroidserver from debian, so probably not the latest version.

[grote]

@machiav3lli thanks for reporting. I'll leave this open to track the fix for this project, but ultimately, this needs to get fixed in and thus reported for fdroidserver as that's the software creating the repo.

[grote]

After updating to latest fdroidserver deploy fails with obscure error. I'll disable publishing to nightly until someone fixes this.

[machiav3lli]

If interesting for you (for client/library), here's my custom serializer to cover both formats for now.