Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove address translation #321

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Remove address translation #321

merged 2 commits into from
Aug 24, 2023

Conversation

DylanTinianov
Copy link
Contributor

Closes: #315

Description

Removed address translation between client and API.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@DylanTinianov DylanTinianov self-assigned this Aug 23, 2023
@DylanTinianov DylanTinianov marked this pull request as ready for review August 23, 2023 18:03
bthaile
bthaile approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@bthaile bthaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DylanTinianov DylanTinianov merged commit d849dcb into v2 Aug 24, 2023
2 checks passed
@DylanTinianov DylanTinianov deleted the refactor/remove-address-translation branch August 24, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthaile bthaile bthaile approved these changes

@turbolent turbolent Awaiting requested review from turbolent

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

@sideninja sideninja Awaiting requested review from sideninja

Assignees

@DylanTinianov DylanTinianov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Address Translation Layer
2 participants
@DylanTinianov @bthaile