Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetTransactionResult BlockHeight always 0 #313

Open
nickdapper opened this issue Aug 12, 2022 · 3 comments
Open

GetTransactionResult BlockHeight always 0 #313

nickdapper opened this issue Aug 12, 2022 · 3 comments
Assignees
Labels
Bug Something isn't working Good First Issue Good for newcomers

Comments

@nickdapper
Copy link

nickdapper commented Aug 12, 2022

Problem

When I call GetTransactionHeight, the BlockHeight field is always zero.

Steps to Reproduce

Following the examples folder using the http package.
Using v0.26.5

Possible cause is here: https://github.com/onflow/flow-go-sdk/blob/master/access/http/convert.go#L367

Not seeing a conversion for the height.

cc @emilic

@sideninja sideninja assigned sideninja and unassigned psiemens Aug 12, 2022
@sideninja sideninja added the Bug Something isn't working label Aug 12, 2022
@sideninja
Copy link
Contributor

Thank you for the report. Good catch. We are in fact not getting that data from the AN. Will provide a fix.

@nickdapper
Copy link
Author

I also noticed that GetCollection always returns an empty list of transactions. Again, this is for the http version.

If I switch over to the grpc method, everything works just fine.

@austinkline
Copy link

Any updates to this? Just ran into both issues reported here so seems like it's still a WIP?

@sideninja sideninja assigned chasefleming and unassigned sideninja Mar 30, 2023
@sideninja sideninja added the Good First Issue Good for newcomers label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Good First Issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants