Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PoP of staking private key for node registration #425

Draft
wants to merge 141 commits into
base: master
Choose a base branch
from

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented May 6, 2024

rebase of #301 against the stable-cadence branch, closes #426

Adds a PoP parameter to the addNodeRecord method in the staking contract.
In the NodeRecord init function, PoP is verified against the staking public key.

Also updates the locked tokens contract, staking collection, and all of their transactions to include this parameter

@tarakby tarakby changed the title WIP: add pop for node registration Add PoP of staking private key for node registration May 7, 2024
@tarakby tarakby self-assigned this May 7, 2024
@tarakby tarakby changed the base branch from stable-cadence to master September 19, 2024 20:13
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good so far! I just had one suggestion about the error message

contracts/FlowIDTableStaking.cdc Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants